Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

differences of transfer matrix method to SpecularReflectivityModel #57

Open
dkriegner opened this issue Sep 3, 2018 · 2 comments
Open
Labels

Comments

@dkriegner
Copy link
Owner

The transfer matrix method implemented in DynamicalReflectivityModel yields identical results to SpecularReflectivityModel

see the examples/simpack_xrr_matrixmethod.py script and the plot it generates
image

The benchmarking shows:

%timeit Reflec_S, Trans_S = model_S.simulate(alpha)
10 loops, best of 3: 56.9 ms per loop

%timeit R_kin = xrr_model.simulate(alpha)
1000 loops, best of 3: 404 µs per loop

that SpecularReflectivity is clearly faster.

If the results are equal under all cases it should be clearly stated in the example script.
If there are differences under certain cases these should be shown in the example script.

@dkriegner
Copy link
Owner Author

@nlaanait: I would be interested to get your opinion on this issue

@dkriegner
Copy link
Owner Author

@nlaanait: bump

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant