refactor: rename StartCommitMessage

Author: gregorriegler

configuration/configuration.go

@@ -20,7 +20,7 @@ type Configuration struct {
 	CliName                        string // override with MOB_CLI_NAME
 	RemoteName                     string // override with MOB_REMOTE_NAME
 	WipCommitMessage               string // override with MOB_WIP_COMMIT_MESSAGE
-	StartCISkipCommitMessage       string // override with MOB_START_COMMIT_MESSAGE
+	StartCommitMessage             string // override with MOB_START_COMMIT_MESSAGE
 	GitHooksEnabled                bool   // override with MOB_GIT_HOOKS_ENABLED
 	RequireCommitMessage           bool   // override with MOB_REQUIRE_COMMIT_MESSAGE
 	VoiceCommand                   string // override with MOB_VOICE_COMMAND
@@ -74,7 +74,7 @@ func Config(c Configuration) {
 	say.Say("MOB_CLI_NAME" + "=" + quote(c.CliName))
 	say.Say("MOB_REMOTE_NAME" + "=" + quote(c.RemoteName))
 	say.Say("MOB_WIP_COMMIT_MESSAGE" + "=" + quote(c.WipCommitMessage))
-	say.Say("MOB_START_COMMIT_MESSAGE" + "=" + quote(c.StartCISkipCommitMessage))
+	say.Say("MOB_START_COMMIT_MESSAGE" + "=" + quote(c.StartCommitMessage))
 	say.Say("MOB_GIT_HOOKS_ENABLED" + "=" + strconv.FormatBool(c.GitHooksEnabled))
 	say.Say("MOB_REQUIRE_COMMIT_MESSAGE" + "=" + strconv.FormatBool(c.RequireCommitMessage))
 	say.Say("MOB_VOICE_COMMAND" + "=" + quote(c.VoiceCommand))
@@ -174,7 +174,7 @@ func GetDefaultConfiguration() Configuration {
 		CliName:                        "mob",
 		RemoteName:                     "origin",
 		WipCommitMessage:               "mob next [ci-skip] [ci skip] [skip ci]",
-		StartCISkipCommitMessage:       "mob start [ci-skip] [ci skip] [skip ci]",
+		StartCommitMessage:             "mob start [ci-skip] [ci skip] [skip ci]",
 		GitHooksEnabled:                false,
 		VoiceCommand:                   voiceCommand,
 		VoiceMessage:                   "mob next",
@@ -230,7 +230,7 @@ func parseUserConfiguration(configuration Configuration, path string) Configurat
 		case "MOB_WIP_COMMIT_MESSAGE":
 			setUnquotedString(&configuration.WipCommitMessage, key, value)
 		case "MOB_START_COMMIT_MESSAGE":
-			setUnquotedString(&configuration.StartCISkipCommitMessage, key, value)
+			setUnquotedString(&configuration.StartCommitMessage, key, value)
 		case "MOB_GIT_HOOKS_ENABLED":
 			setBoolean(&configuration.GitHooksEnabled, key, value)
 		case "MOB_REQUIRE_COMMIT_MESSAGE":
@@ -321,7 +321,7 @@ func parseProjectConfiguration(configuration Configuration, path string) Configu
 		case "MOB_WIP_COMMIT_MESSAGE":
 			setUnquotedString(&configuration.WipCommitMessage, key, value)
 		case "MOB_START_COMMIT_MESSAGE":
-			setUnquotedString(&configuration.StartCISkipCommitMessage, key, value)
+			setUnquotedString(&configuration.StartCommitMessage, key, value)
 		case "MOB_GIT_HOOKS_ENABLED":
 			setBoolean(&configuration.GitHooksEnabled, key, value)
 		case "MOB_REQUIRE_COMMIT_MESSAGE":
@@ -417,7 +417,7 @@ func parseEnvironmentVariables(configuration Configuration) Configuration {
 
 	setStringFromEnvVariable(&configuration.RemoteName, "MOB_REMOTE_NAME")
 	setStringFromEnvVariable(&configuration.WipCommitMessage, "MOB_WIP_COMMIT_MESSAGE")
-	setStringFromEnvVariable(&configuration.StartCISkipCommitMessage, "MOB_START_COMMIT_MESSAGE")
+	setStringFromEnvVariable(&configuration.StartCommitMessage, "MOB_START_COMMIT_MESSAGE")
 	setBoolFromEnvVariable(&configuration.GitHooksEnabled, "MOB_GIT_HOOKS_ENABLED")
 	setBoolFromEnvVariable(&configuration.RequireCommitMessage, "MOB_REQUIRE_COMMIT_MESSAGE")
 	setOptionalStringFromEnvVariable(&configuration.VoiceCommand, "MOB_VOICE_COMMAND")

configuration/configuration_test.go

@@ -201,7 +201,7 @@ func TestReadConfigurationFromFileOverrideEverything(t *testing.T) {
 	test.Equals(t, "team", actualConfiguration.CliName)
 	test.Equals(t, "gitlab", actualConfiguration.RemoteName)
 	test.Equals(t, "team next", actualConfiguration.WipCommitMessage)
-	test.Equals(t, "mob: start", actualConfiguration.StartCISkipCommitMessage)
+	test.Equals(t, "mob: start", actualConfiguration.StartCommitMessage)
 	test.Equals(t, true, actualConfiguration.RequireCommitMessage)
 	test.Equals(t, "whisper \"%s\"", actualConfiguration.VoiceCommand)
 	test.Equals(t, "team next", actualConfiguration.VoiceMessage)

mob.go

@@ -969,7 +969,7 @@ func startNewMobSession(configuration config.Configuration) {
 
 	say.Info("starting new session from " + currentBaseBranch.remote(configuration).String())
 	git("checkout", "-B", currentWipBranch.Name, currentBaseBranch.remote(configuration).Name)
-	git("commit", "--allow-empty", "-m", configuration.StartCISkipCommitMessage)
+	git("commit", "--allow-empty", "-m", configuration.StartCommitMessage)
 	gitPush(gitHooksOption(configuration), "--set-upstream", configuration.RemoteName, currentWipBranch.Name)
 }
 

mob_test.go

@@ -226,7 +226,7 @@ func TestStartWithCISkip(t *testing.T) {
 
 	assertOnBranch(t, "mob-session")
 	assertMobSessionBranches(t, configuration, "mob-session")
-	assertCommitLogContainsMessage(t, "mob-session", configuration.StartCISkipCommitMessage)
+	assertCommitLogContainsMessage(t, "mob-session", configuration.StartCommitMessage)
 }
 
 func TestStartWithMultipleExistingBranches(t *testing.T) {

squash_wip.go

@@ -228,7 +228,7 @@ func isWipCommit(line string, configuration config.Configuration) bool {
 }
 
 func isStartCISkipCommit(line string, configuration config.Configuration) bool {
-	return strings.Contains(line, configuration.StartCISkipCommitMessage)
+	return strings.Contains(line, configuration.StartCommitMessage)
 }
 
 func isPick(line string) bool {

squash_wip_test.go

@@ -158,7 +158,7 @@ func TestSquashWipCommits_acceptanceWithDroppingStartCommit(t *testing.T) {
 		"second manual commit",
 		"first manual commit",
 		configuration.WipCommitMessage,
-		configuration.StartCISkipCommitMessage,
+		configuration.StartCommitMessage,
 	}, commitsOnCurrentBranch(configuration))
 
 	squashWip(configuration)
@@ -187,7 +187,7 @@ func TestCommitsOnCurrentBranch(t *testing.T) {
 	equals(t, []string{
 		configuration.WipCommitMessage,
 		"on branch",
-		configuration.StartCISkipCommitMessage,
+		configuration.StartCommitMessage,
 	}, commits)
 }
 
@@ -314,13 +314,13 @@ pick c51a56d manual commit
 pick 01a9a32 %[1]s
 pick 01a9a33 %[1]s
 
-# Rebase ...`, configuration.WipCommitMessage, configuration.StartCISkipCommitMessage)
+# Rebase ...`, configuration.WipCommitMessage, configuration.StartCommitMessage)
 	expected := fmt.Sprintf(`drop 01a9a31 %[2]s
 pick c51a56d manual commit
 pick 01a9a32 %[1]s
 pick 01a9a33 %[1]s
 
-# Rebase ...`, configuration.WipCommitMessage, configuration.StartCISkipCommitMessage)
+# Rebase ...`, configuration.WipCommitMessage, configuration.StartCommitMessage)
 
 	result := markStartCommitForDropping(input, configuration)