Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate "alt" attribute on images in default template #101

Open
pakal opened this issue Nov 5, 2020 · 0 comments
Open

Duplicate "alt" attribute on images in default template #101

pakal opened this issue Nov 5, 2020 · 0 comments

Comments

@pakal
Copy link

pakal commented Nov 5, 2020

It's a detail, but since the default template (picture.html) uses "{{ instance.attributes_str }}" after already outputting a potential "{{ instance.attributes.alt }}", it gives a duplicated "alt" attribute on final html tag.

I guess it could be solved just by tweaking the "excluded_keys" parameter of the AbstractPicture model's "attributes" field?

Tested on djangocms-picture==2.4.0, but today's master has identical code on these parts so I guess this tiny bug is still there.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant