Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] manage.py cms fixtree does not repair model PageUrl #7904

Open
1 of 2 tasks
jrief opened this issue May 3, 2024 · 1 comment · May be fixed by #7905
Open
1 of 2 tasks

[BUG] manage.py cms fixtree does not repair model PageUrl #7904

jrief opened this issue May 3, 2024 · 1 comment · May be fixed by #7905

Comments

@jrief
Copy link
Contributor

jrief commented May 3, 2024

Description

If the page tree is corrupted, the management command manage.py cms fixtree repairs the the path field in model TreeNode. It however does not repair the path field in model PageUrl.

Steps to reproduce

I don't know how to corrupt the page tree in a reproducible manner, but this probably was caused by another Internal Server Error or race condition. Anyway, take a page find its PageUrl-object and poke an invalid value into the path field.

That page will now be accessible under that new path, but it won't show up in the admin view: Page Tree.

Invoking manage.py cms fixtree does not fix this.

Expected behaviour

In my opinion, manage.py cms fixtree should also fix the PageUrl objects.

Any objections?

Do you want to help fix this issue?

I have a patch.

  • Yes, I want to help fix this issue and I will join #workgroup-pr-review on Slack to confirm with the community that a PR is welcome.
  • No, I only want to report the issue.
@fsbraun
Copy link
Sponsor Member

fsbraun commented May 3, 2024

Well spotted!!

@jrief jrief linked a pull request May 3, 2024 that will close this issue
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants