Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sideframe History Nav Buttons Wrap #7654

Open
1 task done
wesleyboar opened this issue Sep 22, 2023 · 4 comments · May be fixed by #7655
Open
1 task done

Sideframe History Nav Buttons Wrap #7654

wesleyboar opened this issue Sep 22, 2023 · 4 comments · May be fixed by #7655

Comments

@wesleyboar
Copy link

Description

The "CMS Sideframe History" navigation's triangles are wrapping. Tested on three browsers.

Steps to reproduce

  1. Be logged in to your CMS website.
  2. Open your CMS website homepage.
  3. In top CMS admin nav bar, click on (Site Name) > "Administration…"
  4. Look at the top-right of the sidebar that takes up most of the screen.

Expected behaviour

The triangle nav buttons (◀▶) are on one line.

Actual behaviour

The triangle nav buttons (◀▶) are on two lines.

Screenshots

Browser Problem Fix (1 pixel)
Chromium-based brave - sidebar history nav buttons wrap - 65px brave - sidebar history nav buttons fit - 66px
Firefox firefox - sidebar history nav buttons wrap - 65px firefox - sidebar history nav buttons fit - 66px
Safari safari - sidebar history nav buttons wrap - 65px safari - sidebar history nav buttons fit - 66px

Additional information (CMS/Python/Django versions)

Django CMS: 3.11.4
Django: 4.2
Python: 3

Do you want to help fix this issue?

  • Yes, I want to help fix this issue and I will join #workgroup-pr-review on Slack to confirm with the community that a PR is welcome.
  • No, I only want to report the issue.

Note
Culprit code seems to be
https://github.com/django-cms/django-cms/blob/3.11.4/cms/static/cms/sass/components/_sideframe.scss#L99-L100.
@wesleyboar wesleyboar changed the title [BUG] Sideframe History Nav Buttons Wrap Sep 22, 2023
wesleyboar added a commit to wesleyboar/django-cms that referenced this issue Sep 22, 2023
@wesleyboar
Fixed sideframe history nav button wrap.
ffc1080 
Fixes django-cms#7654.
wesleyboar added a commit to wesleyboar/django-cms that referenced this issue Sep 22, 2023
@wesleyboar
fix: sideframe history nav button wrapping
3ab5304 
Fixes django-cms#7654.
@wesleyboar wesleyboar linked a pull request Sep 22, 2023 that will close this issue
Open
3 tasks
@wesleyboar
Copy link
Author

wesleyboar commented Sep 22, 2023 •
edited

I accept the possibility this might be only for me...

Interestingly, I cannot reproduce it right now. — Django CMS Slack #support

@baravkareknath
Copy link

This task is completed or not?

@marksweb
Copy link
Member

@baravkareknath can you reproduce this?

wesleyboar added a commit to wesleyboar/django-cms that referenced this issue Dec 7, 2023
@wesleyboar
Merge branch 'develop' into fix/django-cmsgh-7654-sideframe-hsitory-n…
621c76e 
…av-button-wrap
@wesleyboar
Copy link
Author

wesleyboar commented Dec 7, 2023 •
edited

I'll try to create a reproduction repo when I get bandwidth.

PR is #7655.

wesleyboar added a commit to wesleyboar/django-cms that referenced this issue Feb 9, 2024
@wesleyboar
Merge branch 'develop' into fix/django-cmsgh-7654-sideframe-hsitory-n…
f5c4616 
…av-button-wrap
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: sideframe history nav button wrapping wesleyboar/django-cms
3 participants
@marksweb @baravkareknath @wesleyboar