DEV: Update linting config and run gjs-codemod (#160)

Author: CvX

.discourse-compatibility

@@ -1,3 +1,4 @@
+< 3.5.0.beta5-dev: ca2ed546834ed079b89d83e891ad638b999bdd85
 < 3.5.0.beta3-dev: 6150b4acfbbb2cbd24053845dd90c5e72bee0680
 < 3.5.0.beta1-dev: 8c1a83c481c25deb69e9c25bb93ca667e7c251c4
 < 3.4.0.beta2-dev: 4efb227d5a09c011ae03aac4418f6dac6fb3fc19

Gemfile.lock

@@ -14,42 +14,44 @@ GEM
       securerandom (>= 0.3)
       tzinfo (~> 2.0, >= 2.0.5)
       uri (>= 0.13.1)
-    ast (2.4.2)
-    base64 (0.2.0)
-    benchmark (0.4.0)
-    bigdecimal (3.1.9)
+    ast (2.4.3)
+    base64 (0.3.0)
+    benchmark (0.4.1)
+    bigdecimal (3.2.0)
     concurrent-ruby (1.3.5)
-    connection_pool (2.5.0)
-    drb (2.2.1)
+    connection_pool (2.5.3)
+    drb (2.2.3)
     i18n (1.14.7)
       concurrent-ruby (~> 1.0)
-    json (2.10.2)
-    language_server-protocol (3.17.0.4)
+    json (2.12.2)
+    language_server-protocol (3.17.0.5)
     lint_roller (1.1.0)
-    logger (1.6.6)
+    logger (1.7.0)
     minitest (5.25.5)
-    parallel (1.26.3)
-    parser (3.3.7.1)
+    parallel (1.27.0)
+    parser (3.3.8.0)
       ast (~> 2.4.1)
       racc
     prettier_print (1.2.1)
+    prism (1.4.0)
     racc (1.8.1)
-    rack (3.1.12)
+    rack (3.1.15)
     rainbow (3.1.1)
     regexp_parser (2.10.0)
-    rubocop (1.74.0)
+    rubocop (1.75.8)
       json (~> 2.3)
       language_server-protocol (~> 3.17.0.2)
       lint_roller (~> 1.1.0)
       parallel (~> 1.10)
       parser (>= 3.3.0.2)
       rainbow (>= 2.2.2, < 4.0)
       regexp_parser (>= 2.9.3, < 3.0)
-      rubocop-ast (>= 1.38.0, < 2.0)
+      rubocop-ast (>= 1.44.0, < 2.0)
       ruby-progressbar (~> 1.7)
       unicode-display_width (>= 2.4.0, < 4.0)
-    rubocop-ast (1.38.1)
-      parser (>= 3.3.1.0)
+    rubocop-ast (1.44.1)
+      parser (>= 3.3.7.2)
+      prism (~> 1.4)
     rubocop-capybara (2.22.1)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
@@ -65,13 +67,13 @@ GEM
     rubocop-factory_bot (2.27.1)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
-    rubocop-rails (2.30.3)
+    rubocop-rails (2.32.0)
       activesupport (>= 4.2.0)
       lint_roller (~> 1.1)
       rack (>= 1.1)
-      rubocop (>= 1.72.1, < 2.0)
-      rubocop-ast (>= 1.38.0, < 2.0)
-    rubocop-rspec (3.5.0)
+      rubocop (>= 1.75.0, < 2.0)
+      rubocop-ast (>= 1.44.0, < 2.0)
+    rubocop-rspec (3.6.0)
       lint_roller (~> 1.1)
       rubocop (~> 1.72, >= 1.72.1)
     rubocop-rspec_rails (2.31.0)
@@ -97,4 +99,4 @@ DEPENDENCIES
   syntax_tree
 
 BUNDLED WITH
-   2.6.6
+   2.6.9

assets/javascripts/discourse/components/emoji-images.js renamed to assets/javascripts/discourse/components/emoji-images.gjs

@@ -1,5 +1,7 @@
 import Component from "@ember/component";
 import { classNames } from "@ember-decorators/component";
+import icon from "discourse/helpers/d-icon";
+import htmlSafe from "discourse/helpers/html-safe";
 import computed from "discourse/lib/decorators";
 import { emojiUnescape } from "discourse/lib/text";
 import { i18n } from "discourse-i18n";
@@ -17,4 +19,16 @@ export default class EmojiImages extends Component {
   titleText(title) {
     return i18n(title);
   }
+
+  <template>
+    {{#if this.siteSettings.enable_emoji}}
+      <div title={{this.titleText}}>
+        {{#each this.emojiHTML as |html|}}
+          {{htmlSafe html}}
+        {{/each}}
+      </div>
+    {{else}}
+      {{icon "cake-candles" title=this.titleText}}
+    {{/if}}
+  </template>
 }

assets/javascripts/discourse/components/emoji-images.hbs

@@ -0,0 +1,41 @@
+import Component from "@ember/component";
+import { classNames, tagName } from "@ember-decorators/component";
+import {
+  birthday,
+  birthdayTitle,
+  cakeday,
+  cakedayTitle,
+} from "discourse/plugins/discourse-cakeday/discourse/lib/cakeday";
+import EmojiImages from "../../components/emoji-images";
+
+@tagName("div")
+@classNames("user-card-post-names-outlet", "user-card-cakeday")
+export default class UserCardCakeday extends Component {
+  init() {
+    super.init(...arguments);
+    const { user } = this;
+    this.set("isCakeday", cakeday(user.cakedate));
+    this.set("isBirthday", birthday(user.birthdate));
+    this.set("cakedayTitle", cakedayTitle(user, this.currentUser));
+    this.set("birthdayTitle", birthdayTitle(user, this.currentUser));
+  }
+
+  <template>
+    {{#if this.siteSettings.cakeday_birthday_enabled}}
+      {{#if this.isBirthday}}
+        <EmojiImages
+          @list={{this.siteSettings.cakeday_birthday_emoji}}
+          @title={{this.birthdayTitle}}
+        />
+      {{/if}}
+    {{/if}}
+    {{#if this.siteSettings.cakeday_enabled}}
+      {{#if this.isCakeday}}
+        <EmojiImages
+          @list={{this.siteSettings.cakeday_emoji}}
+          @title={{this.cakedayTitle}}
+        />
+      {{/if}}
+    {{/if}}
+  </template>
+}

assets/javascripts/discourse/connectors/user-card-post-names/user-card-cakeday.gjs

@@ -0,0 +1,75 @@
+import Component from "@ember/component";
+import { hash } from "@ember/helper";
+import { classNames, tagName } from "@ember-decorators/component";
+import { i18n } from "discourse-i18n";
+import ComboBox from "select-kit/components/combo-box";
+
+@tagName("div")
+@classNames("user-custom-preferences-outlet", "user-date-of-birth-input")
+export default class UserDateOfBirthInput extends Component {
+  init() {
+    super.init(...arguments);
+    const { model } = this;
+    const { birthdate } = model;
+    const months = moment.months().map((month, index) => {
+      return {
+        name: month,
+        value: index + 1,
+      };
+    });
+    const days = [...Array(31).keys()].map((d) => (d + 1).toString());
+    const month = birthdate
+      ? moment(birthdate, "YYYY-MM-DD").month() + 1
+      : null;
+    const day = birthdate
+      ? moment(birthdate, "YYYY-MM-DD").date().toString()
+      : null;
+    this.setProperties({
+      months,
+      days,
+      month,
+      day,
+    });
+    const updateBirthdate = () => {
+      let date = "";
+      if (this.month && this.day) {
+        date = `1904-${this.month}-${this.day}`;
+      }
+
+      // The property that is being serialized when sending the update
+      // request to the server is called `date_of_birth`
+      model.set("date_of_birth", date);
+    };
+    this.addObserver("month", updateBirthdate);
+    this.addObserver("day", updateBirthdate);
+  }
+
+  <template>
+    {{#if this.siteSettings.cakeday_birthday_enabled}}
+      <div class="control-group">
+        <label class="control-label">{{i18n "user.date_of_birth.label"}}</label>
+        <div class="controls">
+          <ComboBox
+            @content={{this.months}}
+            @value={{this.month}}
+            @valueAttribute="value"
+            @valueProperty="value"
+            @none="cakeday.none"
+            @options={{hash clearable=true autoInsertNoneItem=false}}
+            @onChange={{action (mut this.month)}}
+          />
+
+          <ComboBox
+            @content={{this.days}}
+            @value={{this.day}}
+            @valueProperty={{null}}
+            @nameProperty={{null}}
+            @none="cakeday.none"
+            @options={{hash clearable=true autoInsertNoneItem=false}}
+            @onChange={{action (mut this.day)}}
+          />
+        </div>
+      </div>
+    {{/if}}
+  </template>
+}

assets/javascripts/discourse/connectors/user-card-post-names/user-card-cakeday.hbs

@@ -0,0 +1,41 @@
+import Component from "@ember/component";
+import { classNames, tagName } from "@ember-decorators/component";
+import {
+  birthday,
+  birthdayTitle,
+  cakeday,
+  cakedayTitle,
+} from "discourse/plugins/discourse-cakeday/discourse/lib/cakeday";
+import EmojiImages from "../../components/emoji-images";
+
+@tagName("div")
+@classNames("user-post-names-outlet", "user-cakeday")
+export default class UserCakeday extends Component {
+  init() {
+    super.init(...arguments);
+    const { model } = this;
+    this.set("isCakeday", cakeday(model.cakedate));
+    this.set("isBirthday", birthday(model.birthdate));
+    this.set("cakedayTitle", cakedayTitle(model, this.currentUser));
+    this.set("birthdayTitle", birthdayTitle(model, this.currentUser));
+  }
+
+  <template>
+    {{#if this.siteSettings.cakeday_birthday_enabled}}
+      {{#if this.isBirthday}}
+        <EmojiImages
+          @list={{this.siteSettings.cakeday_birthday_emoji}}
+          @title={{this.birthdayTitle}}
+        />
+      {{/if}}
+    {{/if}}
+    {{#if this.siteSettings.cakeday_enabled}}
+      {{#if this.isCakeday}}
+        <EmojiImages
+          @list={{this.siteSettings.cakeday_emoji}}
+          @title={{this.cakedayTitle}}
+        />
+      {{/if}}
+    {{/if}}
+  </template>
+}