Skip to content
This repository has been archived by the owner on Dec 24, 2021. It is now read-only.

Problems with the CommandDispatcher interface? #390

Open
GreenCappuccino opened this issue Apr 4, 2021 · 0 comments
Open

Problems with the CommandDispatcher interface? #390

GreenCappuccino opened this issue Apr 4, 2021 · 0 comments
Labels

Comments

@GreenCappuccino
Copy link

GreenCappuccino commented Apr 4, 2021

The handleMessage method in CommandDispatcher is private. This doesn't seem to make sense?

handleMessage is called in the constructor of the Commando client, and nothing in CommandDispatcher actually calls it.

So, it seems like this should be a public method? I'm writing a child class in TypeScript of CommandDispatcher to intercept all messages, and this interface definition is causing problems.

Is there a design decision behind this, or should this be changed?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

2 participants