-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unreachable code in thumbhash_encoder_create function #129
Comments
skidder
added a commit
to skidder/lilliput
that referenced
this issue
Aug 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The
thumbhash_encoder_create
function includes a null-check on the return value fromnew
; however, ifnew
were to fail, the default behavior is to throw anstd::bad_alloc
exception rather than return null, making theif
-condition unreachable.lilliput/thumbhash.cpp
Lines 18 to 21 in 217a9d5
The text was updated successfully, but these errors were encountered: