minor new release

[king-11]

it has been 8 months since the last release the window-sys package change might be useful further upstream allowing users to fetch only one dependency so if it makes sense can we have a new release?

[soc]

Hi @king-11,

the window-sys package change might be useful further upstream allowing users to fetch only one dependency

which one?

Thanks,

Simon

[king-11]

Most of the crates are using windows-sys 0.52 like tokio, request, tempfile, etc. so if dirs is used with them then it would pull in 0.48 for now without latest change.

[ScratchCat458]

In version 0.59.0 the HANDLE type alias has changed: [1] [2]

pub type HANDLE = *mut c_void; // 0.59.0 [1]
pub type HANDLE = isize; // 0.52.0 [2]

This is backwards incompatible with this line in lib.rs and is a fairly quick fix:

  let result = Shell::SHGetKnownFolderPath(
              &folder_id,
              0,
-             Win32::Foundation::HANDLE::default(),
+             std::ptr::null_mut(),
              &mut path_ptr
          );

Upgrading to support 0.59 would have to come at the cost of being unable to support the current version range (>= 0.48.0, < 0.53.0).

Worth keeping an eye on this regarding what the rest of the ecosystem is using, but unsure how we should proceed.

[king-11]

Yeah I think there should be some version that supports a larger set of versions before proceeding onto a bump that would break backwards compatibility.

[king-11]

@soc any thoughts how can be proceed to be in sync with the ecosystem referring the latest tokio Cargo.toml the max version is 0.52.0