-
Notifications
You must be signed in to change notification settings - Fork 47
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add better descriptions as to what causes None to be returned. #44
Comments
Regards this, could you provide more information on the nature of what is to be returned |
If you indulge me, I could return a struct, which will contain the PathBuf if any, and an error message if none |
Like a |
A result that returns the Ok(Pathbuf) or an Err(Strong) |
Yeah I think that is a better solution that the current Some/None strategy. Having some way to understand what failed to happen is better than it failing with no context. I am not entirely sure what the original context was of this issue, let me review the code I used that faced this issue and get back to you. |
I looked it up, I think it's coming from the dir-sys crate |
The main concern when I thought about this pre-1.0 was that the errors that may show up in the failure case are hard to predict/test/standardize across platforms. |
Hmmm 🤔 |
Now, the challenge is getting the error cause, which would be better than a generic message I suggested earlier |
Currently the documentation is vague about what causes None returns in functions. It would be very helpful to be able to not have to comb through the code to implement the api calls and know what is happening if None is returned.
The text was updated successfully, but these errors were encountered: