Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Question/Feature Return error instead of compiler-error on non-supported platforms #3

Open
niklasad1 opened this issue Jul 18, 2018 · 1 comment
Open

Question/Feature Return error instead of compiler-error on non-supported platforms #3

niklasad1 opened this issue Jul 18, 2018 · 1 comment

Comments

@niklasad1
Copy link

Hey,

What's your opinions on providing dummy implementation (returning None) for platforms that are not Windows, Linux or OSX?

If you are positive to this I have a branch ready to do that and can create a PR!
@niklasad1 niklasad1 changed the title Question/Feature Return error instead of compile-time on non-supported platforms Question/Feature Return error instead of compiler-error on non-supported platforms Jul 18, 2018
@soc
Copy link
Collaborator

soc commented Jul 23, 2018

Hi @niklasad1, I don't have a fixed opinion on it, and would love to hear your position.

Which platforms do you have in mind? What would be the benefits? Wouldn't it be better to just fail compilation?

(Although I feel like with the deprecation of std::env::home_dir I'm now on the hook for supporting pretty much every operating system under the sun ...)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@soc @niklasad1