Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: reduce cyclomatic complexity 34 in VEXXHOST provisioner #299

Open
dirien opened this issue Nov 24, 2021 · 0 comments
Open

fix: reduce cyclomatic complexity 34 in VEXXHOST provisioner #299

dirien opened this issue Nov 24, 2021 · 0 comments
Labels
cloud-provider enhancement New feature or request good first issue Good for newcomers

Comments

@dirien
Copy link
Owner

dirien commented Nov 24, 2021

The VEXXHOST provisioner has a function with a very high cyclomatic

pkg/cloud/vexxhost/vexxhost.go:96:1: cyclomatic complexity 34 of func `(*VEXXHOST).CreateServer` is high (> 30) (gocyclo)
func (v *VEXXHOST) CreateServer(args automation.ServerArgs) (*automation.RessourceResults, error) {

We should split the fn to reduce the complexity
@dirien dirien added enhancement New feature or request good first issue Good for newcomers cloud-provider labels Nov 24, 2021
@dirien dirien changed the title fix: reduce cyclomatic complexity 33 in VEXXHOST provisioner fix: reduce cyclomatic complexity 34 in VEXXHOST provisioner Nov 24, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
cloud-provider enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dirien