Add Support for Custom FavIcon Images #4184
Replies: 9 comments 24 replies
-
|
Converting this to a discussion since this is not actually a bug. :) While it does make sense to display the PNG in the favicon, as of now we're only using the color in the favicon. When you add a logo we DO remove the Directus logo though. The issue here is that a 40x40 image will likely not scale very well to 16x16. I think if we want to have custom favicons we should have a dedicated field for it within Project Settings. |
Beta Was this translation helpful? Give feedback.
-
|
Oh Alright I see. In the doc it says that the logo is used to dynamically set as favicon so I tought it was a bug. But yeah a dedicated field for the Favicon would be a nice feature :) Thank you for the answer 👍 |
Beta Was this translation helpful? Give feedback.
-
|
(Updated the docs to reflect this 👍🏻 3511738) |
Beta Was this translation helpful? Give feedback.
-
|
Hmm, I'm not seeing this. The Docs reference the color for favicon. https://docs.directus.io/guides/projects/#adjusting-project-settings Is there somewhere else in the Docs that mentions the logo is used in the favicon? |
Beta Was this translation helpful? Give feedback.
-
|
See the commit I linked :)
It used to say logo and color, I changed it to just mention the color, which is accurate |
Beta Was this translation helpful? Give feedback.
-
|
Having the option to upload an image for the favicon would be great! |
Beta Was this translation helpful? Give feedback.
-
|
Also I think it would be nice if you could also have a checkbox saying "use logo as favicon" instead of uploading 2 times the same icon. Since svg favicons are a thing these days also normal logos can in fact scale very well down to be used as favicons aswell. |
Beta Was this translation helpful? Give feedback.
-
|
Then why do I sometimes see a Directus favicon? Can you add a field in the settings where admin can enter a favicon file. Or admin can simply replace from the list of Directus files - this favicon with own - this is the simplest solution. |
Beta Was this translation helpful? Give feedback.
-
|
That's the default. When a project logo is configured, it's replaced with a white-labelled alternative (the circle without logo). The configured project color is used as the color of the favicon.
This is actually not at simple solution at all.. The file is bundled in and served from the distributions in the node_modules folders. Every time you'd update the platform the files are replaced completely. It will have to come from a field in project settings 👍🏻 |
Beta Was this translation helpful? Give feedback.
-
|
Great idea with the favicon placed locally, just like other project files, and in the settings to be marked which one it is. I had experience with joomla before, and here it is done differently. Well, good luck in solving the problem. |
Beta Was this translation helpful? Give feedback.
-
|
This would be a very nice feature |
Beta Was this translation helpful? Give feedback.
-
|
I would have it the other way around. By default the logo uploaded should be used for favicon as well unless you tick the checkbox and upload another one. But, to be honest, the checkbox is just a nice to have and the logo being used as a favicon would be enough. It wouldn't even be that hard to do either since the directus logo is applied without a custom logo selected. |
Beta Was this translation helpful? Give feedback.
-
|
The colored circle in my web browser tab for my Directus project honestly almost looks like a glitch, like something is broken or not loading in properly. I know it isn't, but it'd be a lot more obvious if I could just specify an PNG image to use instead.
|
Beta Was this translation helpful? Give feedback.
-
|
Happy to support this, but not an internal priority. Would love to discuss implementation and coordinate a PR. |
Beta Was this translation helpful? Give feedback.
-
|
Just to add onto this but most project colors would have a darker background to them considering it also acts as the background color for a custom logo. On dark-themed browsers, the project color blends in with the tab bar making it visually hard to identify an open Directus tab. For example, on my browser this is what I see:
You could imagine, with more tabs, the more difficult it gets to visually identify your Directus tab. |
Beta Was this translation helpful? Give feedback.
-
|
Thinking aloud and breaking this down: would this be
|
Beta Was this translation helpful? Give feedback.
-
I wouldn't want to make that assumption for all users
Yup! that's exactly it. The only other thing we'll have to add is the additional "allowed public key" to the /server/info endpoint, so we can read the favicon from the public role |
Beta Was this translation helpful? Give feedback.
-
|
Just reviving this since today I found out that on safar the directus logo still shows even though I do have custom logo set. |
Beta Was this translation helpful? Give feedback.
-
|
@rijkvanzanten @u12206050 This is with reference to #4184 The favicon does not work for safari and in some versions of Microsoft edge. And as a side note maybe a feature request to be allowed to upload a custom favicon, in the Directus settings. Originally posted by @sksar in #11952 (comment) |
Beta Was this translation helpful? Give feedback.
-
|
Yeah! |
Beta Was this translation helpful? Give feedback.
-
Hmm. This is very random. It appears in some cases, and does not in some cases, even if it's the same computer and browser. Maybe it's best to remove it fully and have it user settable, or a fixed favicon, or no favicon. |
Beta Was this translation helpful? Give feedback.
-
|
Remove the functionality and use the static one, would be nice. |
Beta Was this translation helpful? Give feedback.
-
|
If done properly, I'm open to a PR that adds an override favicon image within the general settings. Unfortunately, this would be too low prior for us to take on internally in the short term. |
Beta Was this translation helpful? Give feedback.
-
|
Heya! Thanks for opening this feature request! This feature request has received over 15 votes from the community. This means we'll move this feature request to the Under Review state! The Core team will schedule a meeting to review this request as soon as possible. The discussion will then be approved or denied. You may or may not be invited to join this meeting with the core team. For more information, see our Feature Request Process. |
Beta Was this translation helpful? Give feedback.
-
|
Yes, please. |
Beta Was this translation helpful? Give feedback.
-
|
Add favicon to Project Settings -- Do as part of new theming update |
Beta Was this translation helpful? Give feedback.
-
|
This was implemented and will ship as part of 10.7 very soon 😄 |
Beta Was this translation helpful? Give feedback.
-
|
Yaassss!!! |
Beta Was this translation helpful? Give feedback.
-
The logo in the module bar gets updated, but the Favicon doesn't display anything.
I tried with a white png and svg 40x40, but still doesn't display the Favicon.
Beta Was this translation helpful? Give feedback.
All reactions