Remove Hipchat integration, fixes errbit#1499 (errbit#1500)

* Remove Hipchat integration, fixes errbit#1499

Also see errbit#1498

Author: 2called-chaos

.rubocop_todo.yml

@@ -41,14 +41,6 @@ Layout/IndentAssignment:
   Exclude:
     - 'app/models/problem.rb'
 
-# Offense count: 1
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle.
-# SupportedStyles: auto_detection, squiggly, active_support, powerpack, unindent
-Layout/IndentHeredoc:
-  Exclude:
-    - 'app/models/notification_services/hipchat_service.rb'
-
 # Offense count: 3
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle.
@@ -242,7 +234,6 @@ Style/AccessModifierDeclarations:
     - 'app/helpers/apps_helper.rb'
     - 'app/mailers/mailer.rb'
     - 'app/models/backtrace.rb'
-    - 'app/models/notification_services/hipchat_service.rb'
     - 'app/models/user.rb'
     - 'lib/hoptoad.rb'
     - 'lib/overrides/hoptoad_notifier/hoptoad_notifier.rb'
@@ -270,7 +261,6 @@ Style/ClassAndModuleChildren:
     - 'app/models/notification_services/campfire_service.rb'
     - 'app/models/notification_services/flowdock_service.rb'
     - 'app/models/notification_services/gtalk_service.rb'
-    - 'app/models/notification_services/hipchat_service.rb'
     - 'app/models/notification_services/hoiio_service.rb'
     - 'app/models/notification_services/hubot_service.rb'
     - 'app/models/notification_services/pushover_service.rb'
@@ -494,7 +484,6 @@ Style/SymbolArray:
 Style/TernaryParentheses:
   Exclude:
     - 'app/helpers/sort_helper.rb'
-    - 'app/models/notification_services/hipchat_service.rb'
 
 # Offense count: 1
 # Cop supports --auto-correct.

Gemfile

@@ -36,8 +36,6 @@ gem 'hoptoad_notifier', "~> 2.4"
 # Notification services
 # ---------------------------------------
 gem 'campy'
-# Hipchat
-gem 'hipchat'
 # Google Talk
 gem 'xmpp4r', require: ["xmpp4r", "xmpp4r/muc"]
 # Hoiio (SMS)

Gemfile.lock

@@ -128,9 +128,6 @@ GEM
       temple (>= 0.8.0)
       tilt
     hashie (4.1.0)
-    hipchat (1.6.0)
-      httparty
-      mimemagic
     hoi (0.0.7)
       httparty
       json
@@ -188,9 +185,6 @@ GEM
     mime-types (3.1)
       mime-types-data (~> 3.2015)
     mime-types-data (3.2016.0521)
-    mimemagic (0.3.9)
-      nokogiri (~> 1)
-      rake
     mini_mime (1.0.1)
     mini_portile2 (2.5.0)
     minitest (5.14.0)
@@ -446,7 +440,6 @@ DEPENDENCIES
   flowdock
   font-awesome-rails
   haml (~> 5.1)
-  hipchat
   hoi
   hoptoad_notifier (~> 2.4)
   htmlentities

app/models/notification_services/hipchat_service.rb

@@ -17,10 +17,6 @@
   room_id { sequence(:room_id) { |i| "#room-#{i}" } }
 end
 
-Fabricator :hipchat_notification_service, from: :notification_service, class_name: "NotificationServices::HipchatService" do
-  service { 'v2' }
-end
-
 %w(campfire flowdock hoiio hubot pushover webhook).each do |t|
   Fabricator "#{t}_notification_service".to_sym, from: :notification_service, class_name: "NotificationServices::#{t.camelcase}Service"
 end

spec/fabricators/notification_service_fabricator.rb

@@ -143,22 +143,6 @@
     end
   end
 
-  describe 'hipcat notifications' do
-    let(:notification_service) { Fabricate(:hipchat_notification_service) }
-    let(:notice_attrs) { notice_attrs_for.call(app.api_key) }
-    let(:app) { Fabricate(:app, notification_service: notification_service) }
-
-    before { Errbit::Config.per_app_notify_at_notices = true }
-    after { Errbit::Config.per_app_notify_at_notices = false }
-
-    it 'creates a hipchat notification' do
-      error_report = ErrorReport.new(notice_attrs)
-      expect(error_report.app.notification_service).
-        to receive(:create_notification)
-      error_report.generate_notice!
-    end
-  end
-
   describe "should send a notification at desired intervals" do
     let(:notification_service) do
       Fabricate(:campfire_notification_service, notify_at_notices: [1, 2])