Rubocop: hashes: format neatly with symbols for keys and aligned values

Author: rud

.rubocop.yml

@@ -36,6 +36,9 @@ Style/DotPosition:
 Style/IndentHash:
   EnforcedStyle: consistent
 
+Style/AlignHash:
+  EnforcedColonStyle: table
+
 Style/SpaceAroundOperators:
   MultiSpaceAllowedForOperators:
     - '='

.rubocop_todo.yml

@@ -53,17 +53,6 @@ Rails/Validation:
     - 'app/models/problem.rb'
     - 'app/models/user.rb'
 
-# Offense count: 8
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedHashRocketStyle, EnforcedColonStyle, EnforcedLastArgumentHashStyle, SupportedLastArgumentHashStyles.
-Style/AlignHash:
-  Exclude:
-    - 'app/models/app.rb'
-    - 'spec/controllers/apps_controller_spec.rb'
-    - 'spec/controllers/comments_controller_spec.rb'
-    - 'spec/controllers/problems_controller_spec.rb'
-    - 'spec/models/problem_spec.rb'
-
 # Offense count: 105
 # Cop supports --auto-correct.
 # Configuration parameters: EnforcedStyle, SupportedStyles, ProceduralMethods, FunctionalMethods, IgnoredMethods.
@@ -141,12 +130,6 @@ Style/FormatString:
 Style/GuardClause:
   Enabled: false
 
-# Offense count: 1168
-# Cop supports --auto-correct.
-# Configuration parameters: EnforcedStyle, SupportedStyles, UseHashRocketsWithSymbolValues.
-Style/HashSyntax:
-  Enabled: false
-
 # Offense count: 6
 # Cop supports --auto-correct.
 # Configuration parameters: MaxLineLength.

Gemfile

@@ -29,8 +29,8 @@ gem 'htmlentities'
 gem 'kaminari', '>= 0.14.1'
 gem 'mongoid', '5.0.0'
 gem 'mongoid_rails_migrations'
-gem 'rack-ssl', :require => 'rack/ssl' # force SSL
-gem 'rack-ssl-enforcer', :require => false
+gem 'rack-ssl', require: 'rack/ssl' # force SSL
+gem 'rack-ssl-enforcer', require: false
 gem 'rails_autolink'
 gem 'useragent'
 
@@ -44,7 +44,7 @@ gem 'campy'
 # Hipchat
 gem 'hipchat'
 # Google Talk
-gem 'xmpp4r', :require => ["xmpp4r", "xmpp4r/muc"]
+gem 'xmpp4r', require: ["xmpp4r", "xmpp4r/muc"]
 # Hoiio (SMS)
 gem 'hoi'
 # Pushover (iOS Push notifications)
@@ -64,7 +64,7 @@ gem 'yajl-ruby', platform: 'ruby'
 gem 'json', platform: 'jruby'
 
 group :development, :test do
-  gem 'airbrake', :require => false
+  gem 'airbrake', require: false
   gem 'pry-rails'
   gem 'pry-byebug', platforms: [:mri]
   gem 'quiet_assets'
@@ -103,7 +103,7 @@ group :heroku, :production do
   gem 'unicorn', require: false, platform: 'ruby'
 end
 
-gem 'therubyracer', :platform => :ruby # C Ruby (MRI) or Rubinius, but NOT Windows
+gem 'therubyracer', platform: :ruby # C Ruby (MRI) or Rubinius, but NOT Windows
 gem 'sass-rails'
 gem 'uglifier'
 # We can't upgrade because not compatible to jquery >= 1.9.

Rakefile

@@ -8,7 +8,7 @@ Rails.application.load_tasks
 begin
   require 'rspec/core/rake_task'
   RSpec::Core::RakeTask.new(:spec)
-  task :default => :spec
+  task default: :spec
 rescue LoadError
   warn "Notice: no rspec tasks available in this environment"
 end

app/controllers/api/v1/notices_controller.rb

@@ -8,16 +8,16 @@ def index
     if params.key?(:start_date) && params.key?(:end_date)
       start_date = Time.zone.parse(params[:start_date]).utc
       end_date = Time.zone.parse(params[:end_date]).utc
-      query = { :created_at => { "$lte" => end_date, "$gte" => start_date } }
+      query = { created_at: { "$lte" => end_date, "$gte" => start_date } }
     end
 
     results = benchmark("[api/v1/notices_controller] query time") do
-      Notice.where(query).with(:consistency => :strong).only(fields).to_a
+      Notice.where(query).with(consistency: :strong).only(fields).to_a
     end
 
     respond_to do |format|
-      format.any(:html, :json) { render :json => JSON.dump(results) } # render JSON if no extension specified on path
-      format.xml { render :xml => results }
+      format.any(:html, :json) { render json: JSON.dump(results) } # render JSON if no extension specified on path
+      format.xml { render xml: results }
     end
   end
 end

app/controllers/api/v1/problems_controller.rb

@@ -13,8 +13,8 @@ def show
     end
 
     respond_to do |format|
-      format.any(:html, :json) { render :json => result } # render JSON if no extension specified on path
-      format.xml { render :xml => result }
+      format.any(:html, :json) { render json: result } # render JSON if no extension specified on path
+      format.xml { render xml: result }
     end
   end
 
@@ -24,16 +24,16 @@ def index
     if params.key?(:start_date) && params.key?(:end_date)
       start_date = Time.parse(params[:start_date]).utc
       end_date = Time.parse(params[:end_date]).utc
-      query = { :first_notice_at => { "$lte" => end_date }, "$or" => [{ :resolved_at => nil }, { :resolved_at => { "$gte" => start_date } }] }
+      query = { :first_notice_at => { "$lte" => end_date }, "$or" => [{ resolved_at: nil }, { resolved_at: { "$gte" => start_date } }] }
     end
 
     results = benchmark("[api/v1/problems_controller/index] query time") do
-      Problem.where(query).with(:consistency => :strong).only(FIELDS).to_a
+      Problem.where(query).with(consistency: :strong).only(FIELDS).to_a
     end
 
     respond_to do |format|
-      format.any(:html, :json) { render :json => JSON.dump(results) } # render JSON if no extension specified on path
-      format.xml { render :xml => results }
+      format.any(:html, :json) { render json: JSON.dump(results) } # render JSON if no extension specified on path
+      format.xml { render xml: results }
     end
   end
 end

app/controllers/api/v1/stats_controller.rb

@@ -11,21 +11,21 @@ def app
     end
 
     stats = {
-      :name => @app.name,
-      :id => @app.id,
-      :last_error_time => @last_error_time,
-      :unresolved_errors => @app.unresolved_count
+      name:              @app.name,
+      id:                @app.id,
+      last_error_time:   @last_error_time,
+      unresolved_errors: @app.unresolved_count
     }
 
     respond_to do |format|
-      format.any(:html, :json) { render :json => JSON.dump(stats) } # render JSON if no extension specified on path
-      format.xml { render :xml => stats }
+      format.any(:html, :json) { render json: JSON.dump(stats) } # render JSON if no extension specified on path
+      format.xml { render xml: stats }
     end
   end
 
   protected def require_api_key_or_authenticate_user!
     if params[:api_key].present?
-      if (@app = App.where(:api_key => params[:api_key]).first)
+      if (@app = App.where(api_key: params[:api_key]).first)
         return true
       end
     end

app/controllers/api/v3/notices_controller.rb

@@ -15,7 +15,7 @@ def create
       if report.should_keep?
         report.generate_notice!
         render json: {
-          id: report.notice.id,
+          id:  report.notice.id,
           url: app_problem_url(
             report.app,
             report.error.problem_id)

app/controllers/application_controller.rb

@@ -5,7 +5,7 @@ class ApplicationController < ActionController::Base
   before_action :authenticate_user!
   before_action :set_time_zone
 
-  rescue_from ActionController::RedirectBackError, :with => :redirect_to_root
+  rescue_from ActionController::RedirectBackError, with: :redirect_to_root
 
   class StrongParametersWithEagerAttributesStrategy < DecentExposure::StrongParametersStrategy
     def assign_attributes?

app/controllers/apps_controller.rb

@@ -1,9 +1,9 @@
 class AppsController < ApplicationController
   include ProblemsSearcher
 
-  before_action :require_admin!, :except => [:index, :show]
-  before_action :parse_email_at_notices_or_set_default, :only => [:create, :update]
-  before_action :parse_notice_at_notices_or_set_default, :only => [:create, :update]
+  before_action :require_admin!, except: [:index, :show]
+  before_action :parse_email_at_notices_or_set_default, only: [:create, :update]
+  before_action :parse_notice_at_notices_or_set_default, only: [:create, :update]
   respond_to :html
 
   expose(:app_scope) { App }
@@ -55,7 +55,7 @@ def new
   def create
     initialize_subclassed_notification_service
     if app.save
-      redirect_to app_url(app), :flash => { :success => I18n.t('controllers.apps.flash.create.success') }
+      redirect_to app_url(app), flash: { success: I18n.t('controllers.apps.flash.create.success') }
     else
       flash[:error] = I18n.t('controllers.apps.flash.create.error')
       render :new
@@ -65,7 +65,7 @@ def create
   def update
     initialize_subclassed_notification_service
     if app.save
-      redirect_to app_url(app), :flash => { :success => I18n.t('controllers.apps.flash.update.success') }
+      redirect_to app_url(app), flash: { success: I18n.t('controllers.apps.flash.update.success') }
     else
       flash[:error] = I18n.t('controllers.apps.flash.update.error')
       render :edit
@@ -78,7 +78,7 @@ def edit
 
   def destroy
     if app.destroy
-      redirect_to apps_url, :flash => { :success => I18n.t('controllers.apps.flash.destroy.success') }
+      redirect_to apps_url, flash: { success: I18n.t('controllers.apps.flash.destroy.success') }
     else
       flash[:error] = I18n.t('controllers.apps.flash.destroy.error')
       render :show