You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Is there a reason to limit the visibility of sort2 and sort3 to pub(crate)? If not, I propose that the visibility would be changed to pub.
In my case they'd be useful for reimplementing some of the functions in parry. I use f32 version of parry, but occasionally need higher precision. In those cases I copy the original implementation and change f32 to f64. Not having these utility functions available means that I have to copy them too, and change the references.
The text was updated successfully, but these errors were encountered:
Is there a reason to limit the visibility of
sort2
andsort3
topub(crate)
? If not, I propose that the visibility would be changed topub
.In my case they'd be useful for reimplementing some of the functions in parry. I use f32 version of parry, but occasionally need higher precision. In those cases I copy the original implementation and change f32 to f64. Not having these utility functions available means that I have to copy them too, and change the references.
The text was updated successfully, but these errors were encountered: