-
-
Notifications
You must be signed in to change notification settings - Fork 450
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cannot compute the SVD of an empty matrix. #1353
Comments
I will chime in here to say that I think the correct behavior here is for the SVD to succeed, not return My understanding of |
I think that aligns with my intuitions; a matrix with a 0 dimension does have a SVD since you can always express it with valid UΣV* matrices. I think all the function needs to do here is return (identity, original matrix, identity) with at least one of those identity matrices being 0x0 matching the 0-dimension of the input matrix. |
probably, from try_ interface expected panic-free behavior independent on input. just return None if input is incorrect.
The text was updated successfully, but these errors were encountered: