Skip to content

Commit 320dd4b

Browse files
committed
Address more elm-analyse warnings.
1 parent f2f5dbe commit 320dd4b

File tree

9 files changed

+27
-106
lines changed

9 files changed

+27
-106
lines changed

elm-analyse.json

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,5 @@
1+
{
2+
"checks": {
3+
"UnusedImportAlias": false
4+
}
5+
}

src/Analytics.elm

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,11 @@ import Setup.ScreenState as ScreenState exposing (ScreenState)
1212

1313

1414
type alias Event =
15-
{ category : String, action : String, label : Maybe String, value : Maybe Int }
15+
{ category : String
16+
, action : String
17+
, label : Maybe String
18+
, value : Maybe Int
19+
}
1620

1721

1822
trackEvent : Event -> ( model, Cmd Msg ) -> ( model, Cmd Msg )
@@ -60,13 +64,13 @@ operationToEvent mobsterOperation =
6064
MobsterOperation.RotateIn index ->
6165
{ category = "roster", action = "rotate-in", label = Nothing, value = Just index }
6266

63-
MobsterOperation.Add string ->
67+
MobsterOperation.Add _ ->
6468
{ category = "roster", action = "add", label = Nothing, value = Nothing }
6569

66-
MobsterOperation.Reorder mobsterList ->
70+
MobsterOperation.Reorder _ ->
6771
{ category = "roster", action = "reorder", label = Nothing, value = Nothing }
6872

69-
MobsterOperation.CompleteGoal mobsterIndex role goalIndex ->
73+
MobsterOperation.CompleteGoal _ role goalIndex ->
7074
{ category = "roster"
7175
, action = "complete-goal"
7276
, label = Just (toString role ++ "[" ++ toString goalIndex ++ "]")

src/Bootstrap.elm

Lines changed: 8 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -1,10 +1,10 @@
1-
module Bootstrap exposing (Color(..), navbarButton, smallButton)
1+
module Bootstrap exposing (Color(Danger, Primary, Success, Warning), navbarButton, smallButton)
22

3-
import FA exposing (Icon)
4-
import Html exposing (..)
3+
import FA
4+
import Html exposing (Attribute, Html, button, span, text)
55
import Html.Attributes as Attr
6-
import Html.Events exposing (..)
7-
import StylesheetHelper exposing (CssClasses(..), class, classList, id)
6+
import Html.Events exposing (onClick)
7+
import StylesheetHelper exposing (class)
88

99

1010
type Color
@@ -28,7 +28,7 @@ navbarButton textContent clickMsg color faIcon =
2828
else
2929
"fa fa-" ++ faIcon
3030
in
31-
button [ noTab, onClick clickMsg, Attr.class ("btn " ++ btnColorClass color ++ " btn-sm navbar-btn"), class [ BufferRight ] ]
31+
button [ noTab, onClick clickMsg, Attr.class ("btn " ++ btnColorClass color ++ " btn-sm navbar-btn"), class [ StylesheetHelper.BufferRight ] ]
3232
[ text textContent
3333
, span [ Attr.class faIconClass ] []
3434
]
@@ -40,9 +40,9 @@ smallButton textContent clickMsg color faIcon =
4040
[ onClick clickMsg
4141
, noTab
4242
, Attr.class ("btn " ++ btnColorClass color ++ " btn-sm")
43-
, class [ BufferRight ]
43+
, class [ StylesheetHelper.BufferRight ]
4444
]
45-
[ span [ class [ BufferRight ] ] [ text textContent ]
45+
[ span [ class [ StylesheetHelper.BufferRight ] ] [ text textContent ]
4646
, span [ Attr.class (FA.iconClass faIcon) ] []
4747
]
4848

src/Break.elm

Lines changed: 1 addition & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -1,12 +1,4 @@
1-
module Break exposing (..)
2-
3-
4-
timersBeforeNext : Int -> Int -> Int
5-
timersBeforeNext timersSinceBreak timersPerBreak =
6-
if timersSinceBreak >= timersPerBreak then
7-
0
8-
else
9-
timersPerBreak - timersSinceBreak
1+
module Break exposing (breakSuggested, breaksTurnedOn)
102

113

124
breakSuggested : Int -> Int -> Bool

src/Dice.elm

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -11,7 +11,9 @@ animateRoll model =
1111
{ model | dieStyle = Animation.interrupt [ rollAnimation ] model.dieStyle }
1212

1313

14-
animateActiveMobstersShuffle : { a | activeMobstersStyle : Animation.Messenger.State Setup.Msg.Msg } -> { a | activeMobstersStyle : Animation.Messenger.State Setup.Msg.Msg }
14+
animateActiveMobstersShuffle :
15+
{ a | activeMobstersStyle : Animation.Messenger.State Setup.Msg.Msg }
16+
-> { a | activeMobstersStyle : Animation.Messenger.State Setup.Msg.Msg }
1517
animateActiveMobstersShuffle model =
1618
{ model
1719
| activeMobstersStyle =

src/FA.elm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
module FA exposing (Icon(..), iconClass)
1+
module FA exposing (Icon(Gamepad, Github), iconClass)
22

33

44
type Icon

src/IpcSerializer.elm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -41,4 +41,4 @@ serialize msg =
4141
( "TrackEvent", value )
4242

4343
TrackPage string ->
44-
( "TrackPage", Encode.string string )
44+
( "TrackPage", Encode.string string )

src/List/PaddedZip.elm

Lines changed: 0 additions & 33 deletions
This file was deleted.

tests/PaddedZipTests.elm

Lines changed: 0 additions & 49 deletions
This file was deleted.

0 commit comments

Comments
 (0)