You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
There is an inconsistency in attribute naming in \dk.nita.saml20\dk.nita.saml20\Profiles\DKSaml20\Attributes.
Some attributes are named in what I assume is a "BASIC" naming format, for example:
public class DKSaml20CvrNumberAttribute : DKSaml20Attribute
{
/// <summary>
/// Attribute name
/// </summary>
public const string NAME = "dk:gov:saml:attribute:CvrNumberIdentifier";
/// <summary>
/// Creates an attribute with the specified value.
/// </summary>
/// <param name="value">The value.</param>
/// <returns></returns>
public static SamlAttribute Create(string value)
{
return Create(NAME, null, value);
}
}
But then it sets it to "URI" format in NameFormat property which, I assume, is wrong:
protected static SamlAttribute Create(string name, string friendlyName, string value)
{
SamlAttribute att = new SamlAttribute();
att.NameFormat = SamlAttribute.NAMEFORMAT_URI;
Some other attributes are named in URI format, and this is consistent with att.NameFormat = SamlAttribute.NAMEFORMAT_URI:
{
/// <summary>
/// Attribute name
/// </summary>
public const string NAME = "https://data.gov.dk/concept/core/nsis/loa";
On top of this, the medatdata file generated requests all attributes in URI format, fx.: <q1:RequestedAttribute Name="https://data.gov.dk/model/core/eid/professional/cvr" NameFormat="urn:oasis:names:tc:SAML:2.0:attrname-format:uri" isRequired="true"/>
The text was updated successfully, but these errors were encountered:
There is an inconsistency in attribute naming in \dk.nita.saml20\dk.nita.saml20\Profiles\DKSaml20\Attributes.
Some attributes are named in what I assume is a "BASIC" naming format, for example:
But then it sets it to "URI" format in NameFormat property which, I assume, is wrong:
Some other attributes are named in URI format, and this is consistent with att.NameFormat = SamlAttribute.NAMEFORMAT_URI:
On top of this, the medatdata file generated requests all attributes in URI format, fx.:
<q1:RequestedAttribute Name="https://data.gov.dk/model/core/eid/professional/cvr" NameFormat="urn:oasis:names:tc:SAML:2.0:attrname-format:uri" isRequired="true"/>
The text was updated successfully, but these errors were encountered: