Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open up for other validators #23

Open
JornWildt opened this issue Aug 18, 2020 · 0 comments
Open

Open up for other validators #23

JornWildt opened this issue Aug 18, 2020 · 0 comments

Comments

@JornWildt
Copy link

The OIOSAML library is actually quite a versatile tool, since SAML2 is used by other IdPs than just NemLogin. We have used it with success for authenticating with ADFS - but we were forced to use a slightly different validator.

As can be seen in cBrain-dk@90d42ba, we added a new attribute to FederationConfig.cs named "AssertionValidatorType". This in turn is used to instantiate other assertion validators than the built-in versions. See the change to Saml20Assertion.cs in cBrain-dk@90d42ba.

Further more we also reuse the existing validators by opening them up with public and protected virtual properties that allows us to create our own modified inherited versions. In our case, all we needed was to allow attributes without namespace.

I'm not creating a pull request as our changes are too unpolished to include - just supplying them as an example of what we have done.

So, in short, the issue is a wish for a more open validator structure. The current is fine, it just needs to be made public.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant