I have confirmed locally that this works with the following:

CREATE TABLE foo (
    x serial,
    primary key (x)
) WITH SYSTEM VERSIONING;

$ target/debug/diesel print-schema --database-url="mysql://root:[email protected]:4000/db"

// @generated automatically by Diesel CLI.

diesel::table! {
    foo (x, row_end) {
        x -> Unsigned<Bigint>,
    }
}

Without this patch, no output is generated

There is an interesting caveat with this: the hidden row_end column appears as part of the PK. This is accurate to the table, because adding SV does implicitely add the end row to the PK and the default row name is row_end. However, this of course does not compile in Rust because that row isn't reflected.

diesel::table! {
    tab_foo (x, row_end) {
        x -> Unsigned<Bigint>,
    }
}

I still think this simple PR is good to merge as-is because it at least means the tables are seen, and can just be tweaked with s/, row_end\)/)/g (major step up from doing all table definitions by hand). Long term, there could be a better solution for SV, but that would be blocked on MariaDB support

I still think this simple PR is good to merge as-is because it at least means the tables are seen, and can just be tweaked with s/, row_end)/)/g (major step up from doing all table definitions by hand). Long term, there could be a better solution for SV, but that would be blocked on MariaDB support

I would like to disagree here: The code generated by print-schema is expected to compile without modifications. So that needs to be fixed.

That makes sense too. I think that all that is needed is to ignore the last PK from the group for that table type, so I’ll take a look at how to do that.

I would expect there to be some edge cases but I think that simple change would at least handle the majority. And make it so the joinable macros also get generated, I recently realized they are missing.

Unfortunately I have not had a time to get back to this, anyone is welcome to pick this up if they are willing to