Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[UPSTREAM] The mouse position/target is incorrect if a non zero ui offset is used #38

Open
BenedictWilkins opened this issue Nov 1, 2024 · 2 comments
Open

[UPSTREAM] The mouse position/target is incorrect if a non zero ui offset is used #38

BenedictWilkins opened this issue Nov 1, 2024 · 2 comments
Labels
bug Something isn't working upstream waiting for updates in dependencies

Comments

@BenedictWilkins
Copy link
Contributor

If an offset is used in the UI it seems the guidance arrow doesnt get the correct coordinates.

This is likely a problem with the conversion of mouse coordinates to svg coordinates - THIS IS A BIG PROBLEM.
@BenedictWilkins BenedictWilkins added bug Something isn't working priority:high A high priority issue labels Nov 1, 2024
@BenedictWilkins BenedictWilkins changed the title CRITICAL BUG: the mouse position is incorrect if an non zero ui offset is used CRITICAL BUG: the mouse position is incorrect if a non zero ui offset is used Nov 1, 2024
@BenedictWilkins
Copy link
Contributor Author

BenedictWilkins commented Nov 11, 2024 •
edited
Loading

This has been moved upstream to dicelab-rhul/star-ray-pygame#1

BenedictWilkins added a commit that referenced this issue Nov 11, 2024
@BenedictWilkins
removed ui.offset option, see issue #38
983ba87
BenedictWilkins added a commit that referenced this issue Nov 11, 2024
@BenedictWilkins
removed ui.offset option, see issue #38
429fd79
@BenedictWilkins
Copy link
Contributor Author

commit 429fd79 removes the ui.offset config option. An error is thrown internally by star-ray-pygame if the SVG position is set != (0,0). This issue needs to be fixed upstream.

@BenedictWilkins BenedictWilkins changed the title CRITICAL BUG: the mouse position is incorrect if a non zero ui offset is used [UPSTREAM] The mouse position/target is incorrect if a non zero ui offset is used Nov 11, 2024
@BenedictWilkins BenedictWilkins removed the priority:high A high priority issue label Nov 11, 2024
@BenedictWilkins BenedictWilkins added the upstream waiting for updates in dependencies label Nov 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working upstream waiting for updates in dependencies
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@BenedictWilkins