Bugfix: Hellfire "Life to mana" and "Mana to life" #5771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kphoenix137
force-pushed
the
bugfix-lifetomana-manatolife
branch
from
5ea5118
to
6a5d6f9
Compare
DakkJaniels
reviewed
May 26, 2023
DakkJaniels
reviewed
May 26, 2023
kphoenix137
force-pushed
the
bugfix-lifetomana-manatolife
branch
from
6a5d6f9
to
d0f750a
Compare
kphoenix137
changed the title
kphoenix137
force-pushed
the
bugfix-lifetomana-manatolife
branch
from
59db9df
to
d78f723
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #6875
Hellfire writes the Life and Mana directly to the item. This is a problem since it does not dynamically change the values, but keeps the values from when the item is originally generated. This becomes less of a problem the more frequently the item with one of these powers is regenerated, however it is a terrible way of doing it.
This PR rather sets the Life and Mana values dynamically so they stay accurate to the item description.