Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reshare entity only for increase reach/visibility #83

Open
SuperTux88 opened this issue Sep 11, 2017 · 0 comments
Open

Reshare entity only for increase reach/visibility #83

SuperTux88 opened this issue Sep 11, 2017 · 0 comments

Comments

@SuperTux88
Copy link
Member

SuperTux88 commented Sep 11, 2017

Currently diaspora allows comments and likes on reshares, but that will change in the future to solve diaspora/diaspora#4219.

In the future the reshare entity is only used to increase the reach of a post, all interactions go to the original post and then the post can be displayed only once in the stream.

Because of this, the public flag and the provider_display_name will be removed from the reshare entity, because it doesn't make any sense to make a reshare private when it only increases the visibility of a post. Diaspora currently has the public flag set to always true and the flag was only kept because of the possibility to use the reshare message for quoted reshares too. But since it was decided to not do this in #82, it doesn't make sense anymore to keep them.

There will be a new way to create "reshares" with own interactions, maybe a new quote message or maybe just a status_message with a diaspora:// link to the post, but needs to be discussed first. This discussion will take place here.


Want to back this issue? Post a bounty on it! We accept bounties via Bountysource.

SuperTux88 added a commit to SuperTux88/diaspora_federation that referenced this issue Sep 11, 2017
Also don't extend from Post module anymore to represent the future state
of a reshare as it's own type only used to increase the reach of a post.

See diaspora#83
SuperTux88 added a commit to SuperTux88/diaspora_federation that referenced this issue Sep 11, 2017
SuperTux88 added a commit to SuperTux88/diaspora_federation that referenced this issue Sep 13, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant