Problem on 32-bit archs

[jas4711]

Hi! I help package this for Debian, and we build on several architectures. There is a self-check error on 32-bit platforms, see:

https://salsa.debian.org/jas/golang-github-dgraph-io-ristretto/-/jobs/8028424

In particular:

src/github.com/dgraph-io/ristretto/sketch_test.go:67:8: cannot use 12 << 30 (untyped int constant 12884901888) as int value in assignment (overflows)
src/github.com/dgraph-io/ristretto/store_test.go:209:23: cannot use 4340958203495 (untyped int constant) as int value in argument to z.KeyToHash (overflows)

Two ways to fix this: 1) use other values lower than 2^31 if the number itself isn't critical, or 2) store the constant in a int64 type. What do you think?

[linear]

RSO-5 Problem on 32-bit archs

[matthewmcneely]

I think using a in64 const is the way to go. Or simply

sz := int64(12) << 30

for example. Feel free to send a PR!

Oddly, Ristretto has specific code for 32 bit systems (e.g., calloc_32bit.go), but these tests have been around for years. Maybe you're the first to try in a while!