Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recursive fetching for Google Groups causes timeouts ( >1m auth req times) #3929

Open
3 tasks done
codeknight03 opened this issue Jan 19, 2025 · 2 comments
Open
3 tasks done

Comments

@codeknight03
Copy link

Preflight Checklist

  • I agree to follow the Code of Conduct that this project adheres to.
  • I have searched the issue tracker for an issue that matches the one I want to file, without success.
  • I am not looking for support or already pursued the available support channels without success.

Version

2.41.1

Storage Type

Kubernetes

Installation Type

Official Helm chart

Expected Behavior

This recursive function to fetch google groups makes requests for users with more than 100 groups take longer than standard timeout bounds ( > 30s)

For instance here
argoproj/argo-cd#21420 (comment)

Expected is to be able to not take this long in returning with the groups by either providing a parameter for depth to which groups should be fetched or not to give sub groups in the default response.

Actual Behavior

The recursive fetching takes longer and causes timeouts.

Steps To Reproduce

To Reproduce

  • Ensure user has membership in more than 100 Google Workspace groups. Based on observations, users with fewer than 90 groups successfully complete the authentication flow, while those with more than 110 groups fail.

  • Ensure Dex is enabled with the Google connector and configured to fetch transitive group memberships as instructed in the Argo CD documentation.

  • Attempt to log in to the Argo CD dashboard using Google as the authentication provider.

Though this the core way to reproduce but as pointed out the recursive code would exhibit this behavior for any client be it Argo or not.

Additional Information

No response

Configuration

Logs

@codeknight03
Copy link
Author

I have filed this issue in intention to start writing a DEP for it. I am looking to see if this is an issue the community would like to be addressed then I can start a DEP for this.

@nabokihms
Copy link
Member

Hello, @codeknight03. Sorry for the long delay.|

I believe we do not need a DEP to fix the problem. It would be enough just to discuss the solution briefly in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants