You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I agree to follow the Code of Conduct that this project adheres to.
I have searched the issue tracker for an issue that matches the one I want to file, without success.
Problem Description
We are using Pinniped with Dex in Kubernetes for authenticating Kubernetes users against AD. When LDAP groups are presented to Pinniped for the purpose of assigning group memberships, if the LDAP group case does not match then the group memberships are not matched and the authentication fails.
Proposed Solution
In my understanding, in most LDAP environments, attribute values are considered case-insensitive. Therefore I believe it would be beneficial to have an option in Dex to normalize case for LDAP group IDs (and perhaps user IDs as well) when Dex retrieves them from the directory to avoid this problem. Example code below,
In connector/ldap/ldap.go:
// Config holds configuration options for LDAP logins.typeConfigstruct {
[...]
// If set to true, convert all group names to lower caseNormalizeGroupsbool`json:"normalizeGroups"`// Defaults to false
[...]
func (c*ldapConnector) groups(ctxcontext.Context, userldap.Entry) ([]string, error) {
[...]
// Convert group name to lower case if config value normalizeGroups is trueifc.GroupSearch.NormalizeGroups {
name=strings.ToLower(name)
}
Alternatives Considered
No response
Additional Information
If the community is happy with this approach, I can submit a PR, but first I wanted to float the idea and see if it is welcomed.
The text was updated successfully, but these errors were encountered:
Preflight Checklist
Problem Description
We are using Pinniped with Dex in Kubernetes for authenticating Kubernetes users against AD. When LDAP groups are presented to Pinniped for the purpose of assigning group memberships, if the LDAP group case does not match then the group memberships are not matched and the authentication fails.
Proposed Solution
In my understanding, in most LDAP environments, attribute values are considered case-insensitive. Therefore I believe it would be beneficial to have an option in Dex to normalize case for LDAP group IDs (and perhaps user IDs as well) when Dex retrieves them from the directory to avoid this problem. Example code below,
In
connector/ldap/ldap.go
:Alternatives Considered
No response
Additional Information
If the community is happy with this approach, I can submit a PR, but first I wanted to float the idea and see if it is welcomed.
The text was updated successfully, but these errors were encountered: