fix: respect promptType=none with offline_access scope

automaticgiant · automaticgiant · commit 4f9f13b1a450 · 2025-04-11T21:10:43.000-04:00
diff --git a/connector/oidc/oidc.go b/connector/oidc/oidc.go
@@ -357,7 +357,11 @@ func (c *oidcConnector) LoginURL(s connector.Scopes, callbackURL, state string)
 	}
 
 	if s.OfflineAccess {
-		opts = append(opts, oauth2.AccessTypeOffline, oauth2.SetAuthURLParam("prompt", c.promptType))
+		opts = append(opts, oauth2.AccessTypeOffline)
+		// Only add prompt parameter if it's not "none"
+		if c.promptType != "none" {
+			opts = append(opts, oauth2.SetAuthURLParam("prompt", c.promptType))
+		}
 	}
 	return c.oauth2Config.AuthCodeURL(state, opts...), nil
 }

Original file line number	Diff line number	Diff line change
`@@ -357,7 +357,11 @@ func (c *oidcConnector) LoginURL(s connector.Scopes, callbackURL, state string)`
`357`	`357`	`}`
`358`	`358`
`359`	`359`	`if s.OfflineAccess {`
`360`		`- opts = append(opts, oauth2.AccessTypeOffline, oauth2.SetAuthURLParam("prompt", c.promptType))`
	`360`	`+ opts = append(opts, oauth2.AccessTypeOffline)`
	`361`	`+ // Only add prompt parameter if it's not "none"`
	`362`	`+ if c.promptType != "none" {`
	`363`	`+ opts = append(opts, oauth2.SetAuthURLParam("prompt", c.promptType))`
	`364`	`+ }`
`361`	`365`	`}`
`362`	`366`	`return c.oauth2Config.AuthCodeURL(state, opts...), nil`
`363`	`367`	`}`