From daebf1252024196f3b56d83638eab83f80caa382 Mon Sep 17 00:00:00 2001
From: Eshank Vaish <48060426+eshankvaish@users.noreply.github.com>
Date: Thu, 16 Jan 2025 22:01:00 +0530
Subject: [PATCH] doc: add code comments

---
 src/components/ClusterNodes/NodeDetails.tsx                    | 1 +
 .../ResourceBrowser/ResourceList/BaseResourceList.tsx          | 1 +
 src/components/ResourceBrowser/ResourceList/ResourceList.tsx   | 1 +
 .../appDetails/k8Resource/nodeDetail/NodeDetail.component.tsx  | 3 +--
 4 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/components/ClusterNodes/NodeDetails.tsx b/src/components/ClusterNodes/NodeDetails.tsx
index 382c1c08fd..9827f8649e 100644
--- a/src/components/ClusterNodes/NodeDetails.tsx
+++ b/src/components/ClusterNodes/NodeDetails.tsx
@@ -171,6 +171,7 @@ const NodeDetails = ({ addTab, lowercaseKindToResourceGroupMap, updateTabUrl }:
     }, [location.search])
 
     const selectedResource = useMemo((): { gvk: GVKType; namespaced: boolean } => {
+        // Using - as a prefix since the group is empty for pods
         const resourceGroupData = lowercaseKindToResourceGroupMap[`-${Nodes.Pod.toLowerCase()}`]
         if (!resourceGroupData) {
             return { gvk: { Kind: Nodes.Pod, Group: '', Version: 'v1' }, namespaced: true }
diff --git a/src/components/ResourceBrowser/ResourceList/BaseResourceList.tsx b/src/components/ResourceBrowser/ResourceList/BaseResourceList.tsx
index be77caa4a6..3d9fb2f76b 100644
--- a/src/components/ResourceBrowser/ResourceList/BaseResourceList.tsx
+++ b/src/components/ResourceBrowser/ResourceList/BaseResourceList.tsx
@@ -363,6 +363,7 @@ const BaseResourceListContent = ({
     const renderResourceRow = (resourceData: K8sResourceDetailDataType): JSX.Element => {
         const lowercaseKind = (resourceData.kind as string)?.toLowerCase()
         // This should be used only if shouldOverrideSelectedResourceKind is true
+        // Group and version are not available for Events / shouldOverrideSelectedResourceKind is true
         const gvkFromRawData =
             getFirstResourceFromKindResourceMap(lowercaseKindToResourceGroupMap, lowercaseKind)?.gvk ?? ({} as GVKType)
         // Redirection and actions are not possible for Events since the required data for the same is not available
diff --git a/src/components/ResourceBrowser/ResourceList/ResourceList.tsx b/src/components/ResourceBrowser/ResourceList/ResourceList.tsx
index a4b5541e56..44dd953a70 100644
--- a/src/components/ResourceBrowser/ResourceList/ResourceList.tsx
+++ b/src/components/ResourceBrowser/ResourceList/ResourceList.tsx
@@ -128,6 +128,7 @@ const ResourceList = () => {
         () =>
             (k8SObjectMapRaw?.result.apiResources ?? []).reduce<K8SResourceListType['lowercaseKindToResourceGroupMap']>(
                 (acc, resourceGroup) => {
+                    // Using Group-Kind as key, but we need to move to using map instead
                     acc[`${resourceGroup.gvk.Group.toLowerCase()}-${resourceGroup.gvk.Kind.toLowerCase()}`] =
                         resourceGroup
 
diff --git a/src/components/v2/appDetails/k8Resource/nodeDetail/NodeDetail.component.tsx b/src/components/v2/appDetails/k8Resource/nodeDetail/NodeDetail.component.tsx
index 7e7732c2fc..46c73da286 100644
--- a/src/components/v2/appDetails/k8Resource/nodeDetail/NodeDetail.component.tsx
+++ b/src/components/v2/appDetails/k8Resource/nodeDetail/NodeDetail.component.tsx
@@ -133,8 +133,6 @@ const NodeDetailComponent = ({
         clusterName,
         kind: _selectedResource?.gvk.Kind as string,
         version: _selectedResource?.gvk.Version,
-        // Note: Using the group from the url if available
-        // since kind is mapped to only one group while it doesn't hold true always
         group: _selectedResource?.gvk.Group,
         namespace: params.namespace,
         name: resourceName,
@@ -650,6 +648,7 @@ const NodeDetailComponent = ({
                     setContainers={setContainers}
                     switchSelectedContainer={switchSelectedContainer}
                     selectedNamespaceByClickingPod={selectedResource?.namespace}
+                    // getContainersFromManifest can only be used from resource browser
                     handleSuccess={isResourceBrowserView ? getContainersFromManifest : noop}
                 />
             )}