-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve subtitle merge algorithm #5
Comments
Is this the reason why the subtitle appears wrong ( flipped and sometimes in the wrong order)? |
@obedabit do you have an example? |
@oliverfei Yes I do, here is an example, I have the following photo it has two line sentences, and the output is wrong on one line, it should be two lines and the last sentence should be the first. output: 3 |
Ah ok. That's cause the library doesn't account the multiline scenario at the moment which is unrelated to this issue. |
so should we make an issue for It or you will fix it without one? |
I pushed something if you want to try it out |
It is ok, amazing work |
The subtitle merging algorithm used by this library is too bad for subtitles that appear as if they were typed rather than appearing in a single frame. |
The algorithm currently merges 2 subtitles by picking the one with the highest average confidence.
Ideally, all characters with high confidence should be used if there is no conflict in their positions e.g.
If merging
a (99) b (99) c (99)
anda (99) b (99) a (98) c (99)
, the result should beabac
instead ofabc
The text was updated successfully, but these errors were encountered: