Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature req: JsonPeek not found in cross-trageting projects #87

Open
RobSmyth opened this issue Nov 18, 2024 · 2 comments
Open

Feature req: JsonPeek not found in cross-trageting projects #87

RobSmyth opened this issue Nov 18, 2024 · 2 comments
Labels
bug Something isn't working

Comments

@RobSmyth
Copy link

RobSmyth commented Nov 18, 2024

Describe the Bug

(This is actually a feature request)

When JsonPeek is added to a cross targeting project the project is unable to build as reported in issue #86.

Steps to Reproduce

  1. Add JsonPeek to any project that uses TargetFrameworks instead of TargetFramework.
  2. Build fails with unable to find JsonPeek error.

Expected Behavior

Works in all target builds.

Exception with Stack Trace

Error (active) MSB4036 The "JsonPeek" task was not found. Check the following: 1.) The name of the task in the project file is the same as the name of the task class. 2.) The task class is "public" and implements the Microsoft.Build.Framework.ITask interface. 3.) The task is correctly declared with in the project file, or in the *.tasks files located in the "C:\Program Files\Microsoft Visual Studio\2022\Community\MSBuild\Current\Bin\amd64" directory.

Version Info

Additional Info

I'm happy to look at implementing this as a feature as I've done this with another project.

Back this issue
Back this issue

@RobSmyth RobSmyth added the bug Something isn't working label Nov 18, 2024
@RobSmyth
Copy link
Author

Is there another place to raise a feature request?

@RobSmyth
Copy link
Author

I was successful in adding multi-targeting. But I'm not familiar with .netconfig, it is not apparent to me how you would like to add it nor how it currently builds 😕, so I do not feel that I can raise a PR. Instead, see my hack here.

Change is really simple. It now works on multi-targeting projects.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant