Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

If resx string contains newlines, default comment breaks codegen #308

Closed
kzu opened this issue Jun 4, 2024 · 0 comments · Fixed by #309
Closed

If resx string contains newlines, default comment breaks codegen #308

kzu opened this issue Jun 4, 2024 · 0 comments · Fixed by #309
Labels
bug Something isn't working

Comments

@kzu
Copy link
Member

kzu commented Jun 4, 2024

Since we default the comment to the raw value of the resource string, we cause a build failure in this case.
We should apply the same logic we have for an explicit comment attribute in the resx, which is to replace newlines with spaces.
@kzu kzu added the bug Something isn't working label Jun 4, 2024
kzu added a commit that referenced this issue Jun 4, 2024
@kzu
Sanitize multi-line default comment
117d4b4 
Just as we do for explicit comment.

Fixes #308
@kzu kzu mentioned this issue Jun 4, 2024
Merged
kzu added a commit that referenced this issue Jun 4, 2024
@kzu
Sanitize multi-line default comment
8ad8be7 
Just as we do for explicit comment.

Fixes #308
@kzu kzu closed this as completed in #309 Jun 4, 2024
kzu added a commit that referenced this issue Jun 4, 2024
@kzu
Sanitize multi-line default comment
aed4b2c 
Just as we do for explicit comment.

Fixes #308
@devlooped devlooped locked and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Sanitize multi-line default comment devlooped/ThisAssembly
1 participant
@kzu