Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ThisAssembly.String not generates code for resources #209

Closed
scrolltex opened this issue Mar 2, 2023 · 4 comments
Closed

ThisAssembly.String not generates code for resources #209

scrolltex opened this issue Mar 2, 2023 · 4 comments

Comments

@scrolltex
Copy link

Describe the Bug

I want to use ThisAssembly.Strings, but for me it doesn't generate any code for resource files.
I'm creating an empty console project with Resources.resx file at the root. But generator only creates ThisAssembly.Strings.g.cs.
I try older versions of ThisAssembly and version 1.0.10 is working, but not with 1.1.0.
Am i missing something in the configuration?

Steps to Reproduce

  1. Create empty c# console application (.net 6)
  2. Install ThisAssembly 1.2.9
  3. Create resource file Resources.resx.
  4. Add row with key Foo_Bar and value Baz
  5. Set modifier to Internal
  6. Code for this resource not be generated

Expected Behavior

ThisAssembly.Strings.Foo.Bar to be generated.

Version Info

.NET 6
Visual Studio 2022 17.4.4
ThisAssembly 1.2.9

@scrolltex scrolltex added the bug Something isn't working label Mar 2, 2023
@kzu
Copy link
Member

kzu commented Mar 22, 2023

Followed steps from a clean console app:

image

Could you upload a failing project?

@kzu kzu added need info and removed bug Something isn't working labels Mar 22, 2023
@scrolltex
Copy link
Author

ConsoleApp3.zip

For me this project looks like this:
image

@scrolltex
Copy link
Author

I now tried to install only the ThisAssembly.Strings and in this case it works. But if i additionally install the ThisAssembly.Resources, then the ThisAssembly.Strings no longer generates code for resource file. And therefore, when installing a meta-package, no code is generated from the resource file.

@scrolltex
Copy link
Author

I tried the new version of ThisAssembly 1.2.13 and now everything works as expected. Thank you!

@devlooped devlooped locked and limited conversation to collaborators Sep 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants