Apply factory method defaults to TableRepository/TablePartition constructors

Just in case objects are somehow constructed bypassing the non-nullable requirement for arguments, apply the same default values we apply in the factory methods for consistency.

Fixes #13

Author: kzu

src/TableStorage/TablePartition.cs

@@ -67,16 +67,26 @@ public static ITablePartition<T> Create<T>(
             string? partitionKey = null,
             Func<T, string>? rowKey = null) where T : class
         {
-            tableName ??= tableName ??= defaultTableNames.GetOrAdd(typeof(T),
-                type => type.GetCustomAttribute<TableAttribute>()?.Name ?? DefaultTableName);
-
-            partitionKey ??= (typeof(T).Name.EndsWith("Entity") ?
-                    typeof(T).Name.Substring(0, typeof(T).Name.Length - 6) :
-                    typeof(T).Name);
-
+            tableName ??= GetDefaultTableName<T>();
+            partitionKey ??= GetDefaultPartitionKey<T>();
             rowKey ??= RowKeyAttribute.CreateAccessor<T>();
 
             return new TablePartition<T>(storageAccount, tableName, partitionKey, rowKey);
         }
+
+        /// <summary>
+        /// Gets a default table name for entities of type <typeparamref name="T"/>. Will be the 
+        /// <see cref="TableAttribute.Name"/> if the attribute is present, or <see cref="DefaultTableName"/> otherwise.
+        /// </summary>
+        public static string GetDefaultTableName<T>() =>
+            defaultTableNames.GetOrAdd(typeof(T), type => type.GetCustomAttribute<TableAttribute>()?.Name ?? DefaultTableName);
+
+        /// <summary>
+        /// Gets a default partition key to use for entities of type <typeparamref name="T"/>. Will be the 
+        /// the type name, stripped of a suffix <c>Entity</c> if present.
+        /// </summary>
+        public static string GetDefaultPartitionKey<T>() => typeof(T).Name.EndsWith("Entity") ?
+            typeof(T).Name.Substring(0, typeof(T).Name.Length - 6) :
+            typeof(T).Name;
     }
 }

src/TableStorage/TablePartition`1.cs

@@ -13,38 +13,43 @@ namespace Devlooped
     partial class TablePartition<T> : ITablePartition<T> where T : class
     {
         readonly ITableRepository<T> repository;
-        readonly string partitionKey;
 
         /// <summary>
         /// Initializes the repository with the given storage account and optional table name.
         /// </summary>
         /// <param name="storageAccount">The storage account to use.</param>
         /// <param name="tableName">Optional table name. If no value is provided, <see cref="DefaultTableName"/> will be used.</param>
         public TablePartition(CloudStorageAccount storageAccount, string tableName, string partitionKey, Func<T, string> rowKey)
-            => (this.repository, TableName, this.partitionKey)
-            = (new TableRepository<T>(storageAccount, tableName, _ => partitionKey, rowKey), tableName, partitionKey);
+        {
+            TableName = tableName ?? TablePartition.GetDefaultTableName<T>();
+            PartitionKey = partitionKey ?? TablePartition.GetDefaultPartitionKey<T>();
+            repository = new TableRepository<T>(storageAccount,
+                TableName,
+                _ => PartitionKey,
+                rowKey ?? RowKeyAttribute.CreateAccessor<T>());
+        }
 
         /// <inheritdoc />
         public string TableName { get; }
 
         /// <inheritdoc />
-        public string PartitionKey => partitionKey;
+        public string PartitionKey { get; }
 
         /// <inheritdoc />
         public Task DeleteAsync(T entity, CancellationToken cancellation = default)
             => repository.DeleteAsync(entity, cancellation);
 
         /// <inheritdoc />
         public Task DeleteAsync(string rowKey, CancellationToken cancellation = default)
-            => repository.DeleteAsync(partitionKey, rowKey, cancellation);
+            => repository.DeleteAsync(PartitionKey, rowKey, cancellation);
 
         /// <inheritdoc />
         public IAsyncEnumerable<T> EnumerateAsync(CancellationToken cancellation = default) 
-            => repository.EnumerateAsync(partitionKey, cancellation);
+            => repository.EnumerateAsync(PartitionKey, cancellation);
 
         /// <inheritdoc />
         public Task<T?> GetAsync(string rowKey, CancellationToken cancellation = default)
-            => repository.GetAsync(partitionKey, rowKey, cancellation);
+            => repository.GetAsync(PartitionKey, rowKey, cancellation);
 
         /// <inheritdoc />
         public Task<T> PutAsync(T entity, CancellationToken cancellation = default)

src/TableStorage/TableRepository.cs

@@ -1,6 +1,5 @@
 using System;
 using System.Collections.Concurrent;
-using System.Linq;
 using System.Reflection;
 using Microsoft.Azure.Cosmos.Table;
 
@@ -48,11 +47,18 @@ public static ITableRepository<T> Create<T>(
             Func<T, string>? partitionKey = null,
             Func<T, string>? rowKey = null) where T : class
         {
-            tableName ??= defaultTableNames.GetOrAdd(typeof(T), type => type.GetCustomAttribute<TableAttribute>()?.Name ?? type.Name);
+            tableName ??= GetDefaultTableName<T>();
             partitionKey ??= PartitionKeyAttribute.CreateAccessor<T>();
             rowKey ??= RowKeyAttribute.CreateAccessor<T>();
 
             return new TableRepository<T>(storageAccount, tableName, partitionKey, rowKey);
         }
+
+        /// <summary>
+        /// Gets a default table name for entities of type <typeparamref name="T"/>. Will be the 
+        /// <see cref="TableAttribute.Name"/> if the attribute is present, or the type name otherwise.
+        /// </summary>
+        public static string GetDefaultTableName<T>() =>
+            defaultTableNames.GetOrAdd(typeof(T), type => type.GetCustomAttribute<TableAttribute>()?.Name ?? type.Name);
     }
 }

src/TableStorage/TableRepository`1.cs

@@ -31,10 +31,10 @@ partial class TableRepository<T> : ITableRepository<T> where T : class
         public TableRepository(CloudStorageAccount storageAccount, string tableName, Func<T, string> partitionKey, Func<T, string> rowKey)
         {
             this.storageAccount = storageAccount;
-            table = new AsyncLazy<CloudTable>(() => GetTableAsync(tableName));
-            TableName = tableName;
-            this.partitionKey = partitionKey;
-            this.rowKey = rowKey;
+            TableName = tableName ?? TableRepository.GetDefaultTableName<T>();
+            this.partitionKey = partitionKey ?? PartitionKeyAttribute.CreateAccessor<T>();
+            this.rowKey = rowKey ?? RowKeyAttribute.CreateAccessor<T>();
+            table = new AsyncLazy<CloudTable>(() => GetTableAsync(TableName));
         }
 
         /// <inheritdoc />