Render empty attributes as empty instead of "true" (#42)

developit · Feb 4, 2021 · 339888b · 339888b
1 parent 63200ed
commit 339888b
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 1 deletion.
diff --git a/src/to-vdom.js b/src/to-vdom.js
@@ -52,7 +52,6 @@ function getProps(attrs) {
  let props = {};
  for (let i=0; i<len; i++) {
  let { name, value } = attrs[i];
- if (value==='') value = true;
  if (name.substring(0,2)==='on' && walk.options.allowEvents){
  value = new Function(value); // eslint-disable-line no-new-func
  }

diff --git a/test/index.js b/test/index.js
@@ -85,6 +85,11 @@ describe('Markup', () => {
  );
  });
 
+ it('should render empty attributes as empty', () => {
+ render(<Markup markup={'<img alt="" src="" />'} />, scratch);
+ expect(scratch.firstChild.innerHTML).to.equal('<img alt="" src="">');
+ });
+
  it('should render mapped components from XML', () => {
  const Foo = ({ a, b, camelCasedProperty, children }) =>
  (<div class="foo" camelCasedProperty={camelCasedProperty} data-a={a} data-b={b}>{ children }</div>);