Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Privilege separation conditional check #170

Open
sfuerte opened this issue May 21, 2020 · 3 comments
Open

Privilege separation conditional check #170

sfuerte opened this issue May 21, 2020 · 3 comments

Comments

@sfuerte
Copy link
Contributor

sfuerte commented May 21, 2020

Describe the bug
The subject option has been deprecated since OpenSSH 7.5 (https://www.openssh.com/txt/release-7.5), hence the check shall be conditional.

Expected behavior
No error

Actual behavior

  ×  sshd-16: Server: Use privilege separation
     ×  SSHD Configuration UsePrivilegeSeparation is expected to eq "sandbox"

     expected: "sandbox"
          got: nil

     (compared using ==)

OS / Environment

$ lsb_release -d
Description:	Ubuntu 20.04 LTS

$ ssh -V
OpenSSH_8.2p1 Ubuntu-4, OpenSSL 1.1.1f  31 Mar 2020

Inspec Version

$ inspec --version
4.18.114

Baseline Version

name: ssh-baseline
title: DevSec SSH Baseline
maintainer: DevSec Hardening Framework Team
copyright: DevSec Hardening Framework Team
copyright_email: [email protected]
license: Apache-2.0
summary: Test-suite for best-practice SSH hardening
version: 2.5.6
supports:
  - os-family: unix
@chris-rock
Copy link
Member

chris-rock commented May 22, 2020

@sfuerte Thank you for the hint. I suggest we change the test to ensure that it is not set at all. This allows us to ensure the defaults are used. Any PR is welcome.

@micheelengronne
Copy link
Member

Agreed. Openssh 7.5 is 3 years old. If someone still uses a previous version of SSH, it is another level of problems than this profile can solve.

@micheelengronne
Copy link
Member

#171

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants