Add simple start counter test #498
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This should work in CI (assuming runners aren't reused) but will break after the first run in dev since we don't provide an easy mechanism to clean up volumes. |
| } | ||
|
|
||
| if _, _, err := t.RunExo(ctx, "init"); err != nil { | ||
| return err |
There was a problem hiding this comment.
Since this stuff is only used in tests, it's probably perfectly fine to simply panic on error inside RunExo.
There was a problem hiding this comment.
The intent was to allow people to create end to end tests where failure is expected — which becomes a bit ugly if they have to recover from panics all the time.
brandonbloom
approved these changes
Nov 15, 2021
|
This is blocked on #499 |
|
Squashed and cherry-picked into #543 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.