Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add a parameter to define if we manage nfs server service ensure state #183

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

ttousai
Copy link

@ttousai ttousai commented May 15, 2024

We want puppet-nfs to manage the NFS service but not manage the service state (running/stopped) because that state is managed by another tool.

@TheMeier
Copy link

TheMeier commented Jun 2, 2024

That sounds like an anti pattern to me. No 2 tools should manage the same resource

@tuxmea
Copy link
Member

tuxmea commented Jun 10, 2024

Usually I would agree with the comment #183 (comment)

But other modules are doing the same: class parameter to set the ensure or enable state.

@ttousai can you please rebase your branch?

@h-haaks
Copy link
Member

h-haaks commented Jun 10, 2024

I tend to agree with @TheMeier on this one.
We usually have params to manage the service or not, and if we do manage it we have params to ensure stopped/running and enabled/disabled ( at boot )

If there is another tool involved managing the service state that tool should manage the enabled/disabled state as well.

@tuxmea
Copy link
Member

tuxmea commented Jun 11, 2024

There are reasons why puppet should not start the service. e.g. nfs ist started by pacemaker/corosync.
From my point of view the request to have a parameter makes sense.
Maybe the description was a little bit misleading.

@h-haaks
Copy link
Member

h-haaks commented Jun 11, 2024

To me the example you mention is exactly the kind of edge case where I would set manage_server_service to false and manage the service in a profile class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants