Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sessions don't work #41

Open
cjblomqvist opened this issue Jan 13, 2016 · 3 comments
Open

Sessions don't work #41

cjblomqvist opened this issue Jan 13, 2016 · 3 comments

Comments

@cjblomqvist
Copy link
Contributor

Currently, sessions don't get set properly. This is because the store.modelMiddleware is triggered before the session middleware. I.e. the following line https://github.com/derbyparty/generator-derby/blob/master/app/templates/server/_express.js#L31 needs to move below the session middleware (located here: https://github.com/derbyparty/generator-derby/blob/master/app/templates/server/_express.js#L35 ).

Should both be fixed in the coffee template version and the regular template version. I'm tbh not exactly sure why this happens, but it has something to do with that the store.modelMiddleware middleware triggers adding a express-session kind of instance (or something), but it is prematurely (when it is actually triggered, it cancels because "it's already been initiated" - although not in a proper way).

@curran
Copy link

curran commented Apr 22, 2016

I think I'm encountering this bug. Logging out does not seem to actually log out, the session model tracked by Racer is not getting updated. Not sure how to pinpoint the issue. I also added an issue here derbyparty/derby-login#39

@cjblomqvist
Copy link
Contributor Author

Did you try my proposed fix?

@curran
Copy link

curran commented Apr 27, 2016

No, I will give it a try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants