Skip to content

Introduce modal max-heightΒ #2125

@scurker

Description

@scurker

We currently do not apply a max-height constraint to modals, which can push the controls of the modal down below the fold:

Ideally, we want to keep the controls in view while only scrolling the modal's content.

Things to consider:

Does this apply to all viewport sizes?

If we make the modal content scrollable, it can lead to scenarios where the content itself can shrink down to be unusable if the user needs to zoom in and/or has a smaller viewport height. We may need to consider that at a specific breakpoint the modal will need to default to the current behavior to avoid the dialog content shrinking down too small.

Implementation Details

Dialog inner needs:

max-height: calc(100vh - 130px)

And dialog content needs:

overflow-y: auto;

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions