Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TypeScript outline still available in JS/TS while Deno extension is enabled #493

Open
clo4 opened this issue Aug 13, 2021 · 3 comments
Open
Labels
dx enhancement New feature or request maybe fix available Might have been fixed already

Comments

@clo4
Copy link

clo4 commented Aug 13, 2021

Describe the bug

The built-in TypeScript extension's file outline is still present while the Deno extension is active. I expected the TS extension's outline to be disabled since Deno provides the same data.

To Reproduce

  1. Open a JavaScript or TypeScript file with the extension active.
  2. Open the "Outline" panel.
  3. Observe the available outlines.

Expected behavior

The TypeScript extension's outline should not be present, since it's redundant.

Screenshots

image

Versions

vscode: 1.58.1 deno: 1.13.0 extension: 3.8.0

@kitsonk kitsonk added the enhancement New feature or request label Aug 13, 2021
@kitsonk
Copy link
Contributor

kitsonk commented Aug 31, 2021

I've looked into this and it is somewhat challenging, because of the way the way it is acquired. #514 should fix it partially in certain situations, but there are times where Deno isn't aware that the diagnostics should be disabled, and so it allows them through, but then vscode doesn't do a full refresh, so they can't be suppressed. The only other choice is to assume Deno is enabled by default, which I think would cause a lot of other people frustration as they likely wouldn't get an outline for their non-Deno enabled projects.

@clo4
Copy link
Author

clo4 commented Sep 4, 2021

Wow, that sure is annoying. Thanks for looking into this!

I'm happy with that as a resolution, but it's also fine if you want to leave this issue open to track this for the future :)

@MrPossumz
Copy link

It looks like this issue was run into the the Vue team with their Volar extension. They've included options on their site on how to configure your VS Code to remove the double outline.

See their notes here

@bartlomieju bartlomieju added the dx label Jul 11, 2023
@bartlomieju bartlomieju added the maybe fix available Might have been fixed already label Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dx enhancement New feature or request maybe fix available Might have been fixed already
Projects
None yet
Development

No branches or pull requests

5 participants