Skip to content

Commit 9c2c2da

Browse files
authored
2.2.3 (#205)
1 parent 54d6247 commit 9c2c2da

File tree

3 files changed

+23
-5
lines changed

3 files changed

+23
-5
lines changed

Releases.md

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -2,6 +2,11 @@
22

33
Releases of the extension can be downloaded from [Visual Studio Marketplace](https://marketplace.visualstudio.com/items?itemName=denoland.vscode-deno).
44

5+
### [v2.2.3](https://github.com/denoland/vscode_deno/compare/v2.2.2...v2.2.3) / 2020.09.13
6+
7+
- fix: failed to load typescript-deno-plugin error (#205)
8+
- chore: align ignored diagnostics to Deno 1.4.0 (#205)
9+
510
### [v2.2.2](https://github.com/denoland/vscode_deno/compare/v2.2.1...v2.2.2) / 2020.09.13
611

712
- chore: update tsconfig to match Deno 1.4.0 (#204)

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
"name": "vscode-deno",
33
"displayName": "Deno",
44
"description": "Deno support for VSCode",
5-
"version": "2.2.2",
5+
"version": "2.2.3",
66
"publisher": "denoland",
77
"icon": "deno.png",
88
"galleryBanner": {

typescript-deno-plugin/src/plugin.ts

Lines changed: 17 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,6 @@ import typescript, {
55
CodeFixAction,
66
FormatCodeSettings,
77
UserPreferences,
8-
ImportsNotUsedAsValues,
98
} from "typescript/lib/tsserverlibrary";
109

1110
import { Logger } from "./logger";
@@ -170,8 +169,8 @@ export class DenoPlugin implements typescript.server.PluginModule {
170169
const extraOptions: ts.CompilerOptions = {
171170
isolatedModules: this.configurationManager.config.unstable,
172171
importsNotUsedAsValues: this.configurationManager.config.unstable
173-
? ImportsNotUsedAsValues.Error
174-
: ImportsNotUsedAsValues.Remove,
172+
? this.ts.ImportsNotUsedAsValues.Error
173+
: this.ts.ImportsNotUsedAsValues.Remove,
175174
};
176175

177176
const compilationSettings = merge(
@@ -317,7 +316,21 @@ export class DenoPlugin implements typescript.server.PluginModule {
317316
7016,
318317
];
319318

320-
return diagnostics.filter((v) => !ignoredDiagnostics.includes(v.code));
319+
const ignoredCompileDiagnostics = [
320+
// TS1208: All files must be modules when the '--isolatedModules' flag is
321+
// provided. We can ignore because we guarantuee that all files are
322+
// modules.
323+
1208,
324+
];
325+
326+
return diagnostics.filter(
327+
(v) =>
328+
!ignoredDiagnostics.includes(v.code) &&
329+
!(
330+
this.configurationManager.config.unstable &&
331+
ignoredCompileDiagnostics.includes(v.code)
332+
)
333+
);
321334
};
322335

323336
languageService.getCodeFixesAtPosition = (

0 commit comments

Comments
 (0)