rust_v8 0.98.0,0.99.0 build failure

[chenrui333]

👋 while running deno 1.45.3 build, found some build failure as below:

    --- stderr
    thread 'main' panicked at /tmp/deno-20240723-18844-vtv80a/rusty_v8/build.rs:330:3:
    assertion failed: Command::new(gn()).arg(format!("--script-executable={}",
                                    python())).arg("args").arg(gn_out_dir).arg("--list").status().unwrap().success()
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

full build log, https://github.com/Homebrew/homebrew-core/actions/runs/10058665735/job/27807237240?pr=178170
relates to Homebrew/homebrew-core#178170

[devsnek]

Are you able to get the stdout/stderr from the command failure?

[chenrui333]

still seeing the same error log in the 0.99.0 release build, how should I get the stdout/stderr logs?

    --- stderr
    thread 'main' panicked at /tmp/deno-20240727-18802-qz1dny/rusty_v8/build.rs:330:3:
    assertion failed: Command::new(gn()).arg(format!("--script-executable={}",
                                    python())).arg("args").arg(gn_out_dir).arg("--list").status().unwrap().success()
    note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
  error: failed to compile `deno v1.45.4 (/tmp/deno-20240727-18802-qz1dny/deno/cli)`, intermediate artifacts can be found at `/tmp/deno-20240727-18802-qz1dny/deno/target`.
  To reuse those artifacts with a future compilation, set the environment variable `CARGO_TARGET_DIR` to that path.

relates to Homebrew/homebrew-core#178635

[devsnek]

I think you can change this code:

assert!(Command::new(gn()).arg(format!("--script-executable={}", python())).arg("args").arg(gn_out_dir).arg("--list").status().unwrap().success());

to something like

let output = Command::new(gn()).arg(format!("--script-executable={}", python())).arg("args").arg(gn_out_dir).arg("--list").output().unwrap();
std::io::stderr().write_all(&output.stdout).unwrap();
std::io::stderr().write_all(&output.stderr).unwrap();
assert!(output.status.success());

If there's a way to reproduce the homebrew build locally I can also try to debug it at some point.

[chenrui333]

you can download https://raw.githubusercontent.com/Homebrew/homebrew-core/f1dfb9ef2aa27c6767f26ee10d07158a5cc435d9/Formula/d/deno.rb and run brew install -f /path/to/deno.rb

[devsnek]

@chenrui333 sorry i'm getting this

==> Pouring deno--1.45.4.x86_64_linux.bottle.tar.gz
cp: cannot create regular file '/home/linuxbrew/.linuxbrew/Cellar/deno/./1.45.2/bin/deno': Permission denied
cp: cannot create regular file '/home/linuxbrew/.linuxbrew/Cellar/deno/./1.45.2/bin/denort': Permission denied
Error: Failure while executing; `/usr/bin/env cp -pR /tmp/homebrew-unpack20240727-18829-1m5dz1/deno/. /home/linuxbrew/.linuxbrew/Cellar/deno` exited with 1. Here's the output:
cp: cannot create regular file '/home/linuxbrew/.linuxbrew/Cellar/deno/./1.45.2/bin/deno': Permission denied
cp: cannot create regular file '/home/linuxbrew/.linuxbrew/Cellar/deno/./1.45.2/bin/denort': Permission denied

[devsnek]

Ok fixed the above, turns out the needed command is brew install --build-from-source ./deno.rb. I can reproduce the issue now. Would be helpful if brew didn't delete everything after the build failed...

[pedro-w]

Would be helpful if brew didn't delete everything after the build failed...

Does --keep-tmp help? (https://docs.brew.sh/Manpage#commands)

[chenrui333]

Would be helpful if brew didn't delete everything after the build failed...

I can actually dump out the docs from CI runner, is that good?

[devsnek]

@chenrui333 --keep-tmp worked, but I can't reproduce this manually running build commands in the directory, only under brew install --build-from-source. So it seems like an issue with how brew is putting things together, but I don't know anything about brew, so a brew developer probably needs to take a look.

[devsnek]

@chenrui333 can you try setting NO_PRINT_GN_ARGS=1 when building? I think that might fix it.

[chenrui333]

yeah, totally.

[chenrui333]

somehow it builds fine now 😓

[chenrui333]

since I can no longer reproduce this issue, gonna close it now. Thanks!