-
Notifications
You must be signed in to change notification settings - Fork 484
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Basic curl cheatsheet doesn't work on zsh due to quoting issues #856
Comments
Thanks for opening your first issue here! In case you're facing a bug, please update navi to the latest version first. Maybe the bug is already solved! :) |
Are you open to making a pr for this?
to
The repo is a community cheat sheet, so prs are welcome. Putting quotes around the string, will not break the command for other OSs / shells (it's actually better practice). So it's safe to change the cheat sheet globally. |
Describe the bug
A clear and concise description of what the bug is.
Using the default cheatsheets, the curl examples are broken in zsh for some URLs.
To Reproduce
Steps to reproduce the behavior:
/pat/to/navi repo add denisidoro/cheats
)curl
send a get http request
https://github.com/denisidoro/navi/blob/master/docs/installation.md#installing-the-shell-widget
into the variablecurl https://github.com/denisidoro/navi/blob/master/docs/installation.md#installing-the-shell-widget
zsh: no matches found: https://github.com/denisidoro/navi/blob/master/docs/installation.md#installing-the-shell-widget
Expected behavior
A clear and concise description of what you expected to happen.
Executing the command
curl 'https://github.com/denisidoro/navi/blob/master/docs/installation.md#installing-the-shell-widget'
succeeds, so it looks like a quoting issue.Parameters that contain special characters should be quoted automaticaly.
Screenshots
If applicable, add screenshots to help explain your problem.
N/A
Versions:
Additional context
Add any other context about the problem here.
This is likely to shell-specific, and might be difficult to implement. However it really limits the usefulness of the tool if we need to manually go back in and add quotes around specific parameters.
The text was updated successfully, but these errors were encountered: