Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating a note from a selection does not take into account the read-only workspace settings #3955

Open
2 of 7 tasks
uRohan opened this issue Oct 12, 2023 · 0 comments
Open
2 of 7 tasks
Labels
scope.lookup Anything Lookup related scope.workspace Workspace related functionality (i.e. intellisense, vault, workspace) status.triage-needed type.bug Something isn't working

Comments

@uRohan
Copy link

uRohan commented Oct 12, 2023

Please select the area your bug applies to. (Multiple selections are Possible. You can leave blank if you're not sure.)

  • Workspace. VSCode workspace, vaults, Intellisense/autocomplete, Dendron settings
  • Lookup. Dendron's Lookup Command
  • Views. Dendron Preview, Tree View, Side Panels in the UI
  • Schema. Dendron Schemas
  • Pod. Data import from / export to Dendron
  • Publish. External Site Publish
  • Markdown. Markdown features, such as syntax support and features

Describe the bug

When creating a note from selection, Dendron fails to respect the read-only mode for files within a workspace.
You can read more about read-only mode in VS Code here and here.

To Reproduce

Steps to reproduce the behavior:

  1. Create a new note (e.g., food-calorie-list.apple.md).
  2. Configure the 'files.readonlyInclude' setting in your dendron.code-workspace file: "files.readonlyInclude": {"food-calorie-list.apple.md": true,}
  3. Open a read-only file/note and select a piece of text.
  4. Use Dendron Lookup and choose the option 'Create New'.
  5. Observe that the selected text fragment has been removed from the file/note (food-calorie-list.apple.md) in the read-only mode and was paste into the new note (i.e. the read-only file has been modified).

Expected behavior

Dendron is expected not to modify files marked as read-only in the dendron.workspace file.

Screenshots

If applicable, add screenshots to help explain your problem.

Desktop (please complete the following information)

  • OS: Ubuntu 22.04.3 LTS
  • Browser (if with published websites; include version): N/A
  • Versions (all that apply to bug):
    • Dendron Extension: 0.124.0
    • VS Code version: 1.83.1
    • Dendron CLI: N/A

Additional context

Add any other context about the problem here.

Dendron Log file

Please attach the output of > Dendron:Dev: Open Logs here
N/A

@github-actions github-actions bot added scope.lookup Anything Lookup related scope.workspace Workspace related functionality (i.e. intellisense, vault, workspace) status.triage-needed type.bug Something isn't working labels Oct 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
scope.lookup Anything Lookup related scope.workspace Workspace related functionality (i.e. intellisense, vault, workspace) status.triage-needed type.bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant