Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update remove liquidity; add withdraw shares to state #195

Open
dpaiton opened this issue Sep 13, 2024 · 0 comments
Open

update remove liquidity; add withdraw shares to state #195

dpaiton opened this issue Sep 13, 2024 · 0 comments

Comments

@dpaiton
Copy link
Member

dpaiton commented Sep 13, 2024

remove liquidity needs some updates:

  • add redeem withdraw shares functionality to hyperdrivepy
  • remove liquidity in hyperdrivepy has the incorrect return type
  • track withdraw shares total supply (aka withdraw_shares_asset_id balance) in State
    • this is required for us to estimate PnL (or mock closing LP) in simulation mode
  • use state to access as many of the variables required in the fn signature
    • aka review the fns in remove.rs and ensure that the pattern for signatures matches everywhere else
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant