Remove feature flag on Points Markets page (#1715)

DannyDelott · web-flow · commit 65aed97593d4 · 2025-01-06T12:23:27.000-08:00
* Add fade to pool form

* Remove feature flag
diff --git a/apps/hyperdrive-trading/src/ui/app/Navbar/DevtoolsMenu.tsx b/apps/hyperdrive-trading/src/ui/app/Navbar/DevtoolsMenu.tsx
@@ -20,9 +20,6 @@ export function DevtoolsMenu(): ReactElement {
         <FeatureFlagMenuItem flagName="portfolio-rewards">
           Portfolio Rewards
         </FeatureFlagMenuItem>
-        <FeatureFlagMenuItem flagName="points-markets">
-          Points markets
-        </FeatureFlagMenuItem>
         <MenuItem
           onClick={() => {
             window.localStorage.clear();
diff --git a/apps/hyperdrive-trading/src/ui/app/Navbar/Navbar.tsx b/apps/hyperdrive-trading/src/ui/app/Navbar/Navbar.tsx
@@ -12,7 +12,6 @@ import { useAnalyticsUrl } from "src/ui/analytics/useMarketAnalyticsUrl";
 import { DevtoolsMenu } from "src/ui/app/Navbar/DevtoolsMenu";
 import { HyperdriveLogo } from "src/ui/app/Navbar/HyperdriveLogo";
 import VersionPicker from "src/ui/base/components/VersionPicker";
-import { useFeatureFlag } from "src/ui/base/featureFlags/featureFlags";
 import { useIsTailwindSmallScreen } from "src/ui/base/mediaBreakpoints";
 import { useRegionInfo } from "src/ui/compliance/hooks/useRegionInfo";
 import { LANDING_ROUTE } from "src/ui/landing/routes";
@@ -23,12 +22,9 @@ import { sepolia } from "viem/chains";
 import { useChainId } from "wagmi";
 export function Navbar(): ReactElement {
   const isTailwindSmallScreen = useIsTailwindSmallScreen();
-  const { location } = useRouterState();
   const chainId = useChainId();
   const { isReadOnly } = useRegionInfo();
   const isTestnet = isTestnetChain(chainId);
-  const { isFlagEnabled: isPointsMarketsEnabled } =
-    useFeatureFlag("points-markets");
 
   const analyticsUrl = useAnalyticsUrl();
 
@@ -43,9 +39,7 @@ export function Navbar(): ReactElement {
         </Link>
         <div className="ml-16 flex gap-8">
           <NavbarLink to={LANDING_ROUTE} label="All Pools" />
-          {isPointsMarketsEnabled ? (
-            <NavbarLink to={POINTS_MARKETS_ROUTE} label="Points Markets" />
-          ) : null}
+          <NavbarLink to={POINTS_MARKETS_ROUTE} label="Points Markets" />
           <NavbarLink to={PORTFOLIO_ROUTE} label="Portfolio" />
           {isTestnet ? (
             <NavbarLink to={MINT_ROUTE} label="Mint Tokens" />
diff --git a/apps/hyperdrive-trading/src/ui/markets/PoolDetails.tsx b/apps/hyperdrive-trading/src/ui/markets/PoolDetails.tsx
@@ -11,6 +11,7 @@ import { ArrowTopRightOnSquareIcon } from "@heroicons/react/24/outline";
 import { Link, useSearch } from "@tanstack/react-router";
 import classNames from "classnames";
 import { ReactElement } from "react";
+import { Fade } from "react-awesome-reveal";
 import { ExternalLink } from "src/ui/analytics/ExternalLink";
 import { AccordionSection2 } from "src/ui/base/components/AccordionSection/AccordionSection";
 import CustomBanner from "src/ui/base/components/CustomBanner";
@@ -72,16 +73,18 @@ export function PoolDetails({
         )}
       </div>
       <div className="flex flex-col gap-16">
-        {(() => {
-          switch (activePosition) {
-            case "long":
-              return <OpenLongForm hyperdrive={hyperdrive} />;
-            case "short":
-              return <OpenShortForm hyperdrive={hyperdrive} />;
-            case "lp":
-              return <AddLiquidityForm hyperdrive={hyperdrive} />;
-          }
-        })()}
+        <Fade triggerOnce duration={500}>
+          {(() => {
+            switch (activePosition) {
+              case "long":
+                return <OpenLongForm hyperdrive={hyperdrive} />;
+              case "short":
+                return <OpenShortForm hyperdrive={hyperdrive} />;
+              case "lp":
+                return <AddLiquidityForm hyperdrive={hyperdrive} />;
+            }
+          })()}
+        </Fade>
 
         <AboutThisPool hyperdrive={hyperdrive} />
         <FAQ />
diff --git a/yarn.lock b/yarn.lock
@@ -6411,11 +6411,6 @@
   resolved "https://registry.yarnpkg.com/@xtuc/long/-/long-4.2.2.tgz#d291c6a4e97989b5c61d9acf396ae4fe133a718d"
   integrity sha512-NuHqBY1PB/D8xU6s/thBgOAiAP7HOYDQ32+BFZILJ8ivkUkAHQnWfn6WhL79Owj1qmUnoN/YPhktdIoucipkAQ==
 
-abitype@0.9.8:
-  version "0.9.8"
-  resolved "https://registry.yarnpkg.com/abitype/-/abitype-0.9.8.tgz#1f120b6b717459deafd213dfbf3a3dd1bf10ae8c"
-  integrity sha512-puLifILdm+8sjyss4S+fsUN09obiT1g2YW6CtcQF+QDzxR0euzgEB29MZujC6zMk2a6SVmtttq1fc6+YFA7WYQ==
-
 abitype@1.0.0:
   version "1.0.0"
   resolved "https://registry.yarnpkg.com/abitype/-/abitype-1.0.0.tgz#237176dace81d90d018bebf3a45cb42f2a2d9e97"
@@ -17627,16 +17622,11 @@ typedoc@^0.25.7:
     minimatch "^9.0.3"
     shiki "^0.14.7"
 
-typescript@^5.0.2, typescript@^5.3.3, typescript@^5.4.4, typescript@^5.4.5, typescript@^5.5.4, typescript@~5.5.4:
+typescript@^5.0.2, typescript@^5.3.3, typescript@^5.4.4, typescript@^5.4.5, typescript@^5.5.4, typescript@~5.2.2, typescript@~5.5.4:
   version "5.5.4"
   resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.5.4.tgz#d9852d6c82bad2d2eda4fd74a5762a8f5909e9ba"
   integrity sha512-Mtq29sKDAEYP7aljRgtPOpTvOfbwRWlS6dPRzwjdE+C0R4brX/GUyhHSecbHMFLNBLcJIPt9nl9yG5TZ1weH+Q==
 
-typescript@~5.2.2:
-  version "5.2.2"
-  resolved "https://registry.yarnpkg.com/typescript/-/typescript-5.2.2.tgz#5ebb5e5a5b75f085f22bc3f8460fba308310fa78"
-  integrity sha512-mI4WrpHsbCIcwT9cF4FZvr80QUeKvsUsUvKDoR+X/7XHQH98xYD8YHZg7ANtz2GtZt/CBq2QJ0thkGJMHfqc1w==
-
 ua-parser-js@^1.0.37:
   version "1.0.37"
   resolved "https://registry.yarnpkg.com/ua-parser-js/-/ua-parser-js-1.0.37.tgz#b5dc7b163a5c1f0c510b08446aed4da92c46373f"
@@ -18053,21 +18043,7 @@ vfile@^6.0.0, vfile@^6.0.1:
     unist-util-stringify-position "^4.0.0"
     vfile-message "^4.0.0"
 
-viem@^1.0.0, viem@^1.1.4:
-  version "1.21.4"
-  resolved "https://registry.yarnpkg.com/viem/-/viem-1.21.4.tgz#883760e9222540a5a7e0339809202b45fe6a842d"
-  integrity sha512-BNVYdSaUjeS2zKQgPs+49e5JKocfo60Ib2yiXOWBT6LuVxY1I/6fFX3waEtpXvL1Xn4qu+BVitVtMh9lyThyhQ==
-  dependencies:
-    "@adraffy/ens-normalize" "1.10.0"
-    "@noble/curves" "1.2.0"
-    "@noble/hashes" "1.3.2"
-    "@scure/bip32" "1.3.2"
-    "@scure/bip39" "1.2.1"
-    abitype "0.9.8"
-    isows "1.0.3"
-    ws "8.13.0"
-
-viem@^2.7.8, viem@^2.9.2:
+viem@2.9.2, viem@^1.0.0, viem@^1.1.4, viem@^2.7.8, viem@^2.9.2:
   version "2.9.2"
   resolved "https://registry.yarnpkg.com/viem/-/viem-2.9.2.tgz#29bd2425222be136bf969a90dd3a8d6032221904"
   integrity sha512-GRakUTNiYE9W+vL+Be9JkQfzWnkczerHtSpEe2JR/jEGTYZAs4shrA4WLgiaVCI9JxpnduZhQfRWNvy2dlyP2g==
