-
-
Notifications
You must be signed in to change notification settings - Fork 166
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Skip fill peer connections if webxdc internetAccess is allowed #3844
Comments
webrtc can access anywhere, so no, there is still a need to prefill/disable it. |
On Sat, May 25, 2024 at 06:10 -0700, Simon Laux wrote:
webrtc can access anywhere, so no, there is still a need to prefill/disable it.
especially if we want to make these extension-xdc user replaceable.
we can surely grant our own shipped map-xdc the right to not run FILL500.
FILL500 is for untrusted/3rd party code that we don't know.
If users replace the map app (in the future) we could do FILL 500 still
but not sure that's a 1.46 concern at all.
|
I would suggest to set a list of URLS in the advanced settings which are accessible and set openstreetmap.org as a prefilled default (when location streaming is enabled) |
my opinion: use the core http api for fetching the tiles + maybe specify allowed domains in the webxdc manifest |
Noneed to prefill all 500 connections if internet access is allowed anyway
The text was updated successfully, but these errors were encountered: