-
-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Protect From name for verified chats and To names for encrypted chats (#5166) #5183
Conversation
5b7b83c
to
386258e
Compare
bb72459
to
d467a55
Compare
@link2xt are you fine to merge or do you want to look over it again? |
This does not currently check if the chat is verified, right? I wonder if it is fine to do for non-verified chat since it does not work with Thunderbird, need more opinions from others. |
For me it's better not to complicate the code with additional checks for compatibility with other MUAs if it's not critical. Anyway we need to create a Thunderbird issue (at least i can't find such one). |
1abb12e
to
2af9ff1
Compare
Taking this over, people ask for this feature here: https://support.delta.chat/t/technical-question-encrypt-profile-names/3049 |
d467a55
to
7c05bb2
Compare
… chats (#5166) If a display name should be protected (i.e. opportunistically encrypted), only put the corresponding address to the unprotected headers. We protect the From display name only for verified chats, otherwise this would be incompatible with Thunderbird and K-9 who don't use display names from the encrypted part. Still, we always protect To display names as compatibility seems less critical here. When receiving a messge, overwrite the From display name but not the whole From field as that would allow From forgery. For the To field we don't really care. Anyway as soon as we receive a message from the user, the display name will be corrected. Co-authored-by: iequidoo <[email protected]>
7c05bb2
to
ae13771
Compare
close #5166