Skip to content

Commit bae99e2

Browse files
committed
Add scores to TopMatches
1 parent 5200ad7 commit bae99e2

File tree

3 files changed

+14
-50
lines changed

3 files changed

+14
-50
lines changed

src/main/java/delta/codecharacter/server/controller/api/MatchController.java

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,6 @@
11
package delta.codecharacter.server.controller.api;
22

33
import delta.codecharacter.server.controller.request.UpdateMatchRequest;
4-
import delta.codecharacter.server.controller.response.Match.MatchResponse;
54
import delta.codecharacter.server.service.MatchService;
65
import delta.codecharacter.server.util.PageUtils;
76
import org.springframework.beans.factory.annotation.Autowired;
@@ -36,5 +35,4 @@ public void updateMatch(@RequestBody @Valid UpdateMatchRequest updateMatchReques
3635
return;
3736
matchService.updateMatch(updateMatchRequest);
3837
}
39-
4038
}

src/main/java/delta/codecharacter/server/controller/response/Match/MatchResponse.java

Lines changed: 0 additions & 37 deletions
This file was deleted.

src/main/java/delta/codecharacter/server/service/MatchService.java

Lines changed: 14 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@
66
import delta.codecharacter.server.controller.request.UpdateMatchRequest;
77
import delta.codecharacter.server.controller.response.GameLogs;
88
import delta.codecharacter.server.controller.response.Match.DetailedMatchStatsResponse;
9-
import delta.codecharacter.server.controller.response.Match.MatchResponse;
109
import delta.codecharacter.server.controller.response.Match.PrivateMatchResponse;
1110
import delta.codecharacter.server.model.Match;
1211
import delta.codecharacter.server.model.User;
@@ -107,19 +106,21 @@ public Match createMatch(Integer playerId1, Integer playerId2, MatchMode matchMo
107106
*
108107
* @return list of top matches
109108
*/
110-
public List<MatchResponse> getTopMatches(Integer PageNumber, Integer PageSize) {
109+
public List<PrivateMatchResponse> getTopMatches(Integer PageNumber, Integer PageSize) {
111110
Pageable pageable = PageRequest.of(PageNumber - 1, PageSize);
112111
var topMatches = topMatchRepository.findAllByOrderByCreatedAtDesc(pageable);
113-
List<MatchResponse> matchResponses = new ArrayList<>();
112+
List<PrivateMatchResponse> matchResponses = new ArrayList<>();
114113
for (var topMatch : topMatches) {
115114
Match match = matchRepository.findFirstById(topMatch.getMatchId());
116115
User user1 = userRepository.findByUserId(match.getPlayerId1());
117116
User user2 = userRepository.findByUserId(match.getPlayerId2());
118-
MatchResponse matchResponse = MatchResponse.builder()
117+
PrivateMatchResponse matchResponse = PrivateMatchResponse.builder()
119118
.username1(user1.getUsername())
120119
.username2(user2.getUsername())
121-
.avatarId1(user1.getAvatarId())
122-
.avatarId2(user2.getAvatarId())
120+
.avatar1(user1.getAvatarId())
121+
.avatar2(user2.getAvatarId())
122+
.score1(match.getScore1())
123+
.score2(match.getScore2())
123124
.verdict(match.getVerdict())
124125
.matchMode(match.getMatchMode())
125126
.games(gameService.getAllGamesByMatchId(match.getId()))
@@ -140,12 +141,12 @@ public List<MatchResponse> getTopMatches(Integer PageNumber, Integer PageSize) {
140141
public List<PrivateMatchResponse> getManualAndAutoExecutedMatchesPaginated(Integer userId, Pageable pageable) {
141142
Aggregation aggregation = newAggregation(
142143
match(
143-
new Criteria().andOperator(
144144
new Criteria().andOperator(
145-
new Criteria().orOperator(Criteria.where("player_id_1").is(userId), Criteria.where("player_id_2").is(userId)),
146-
new Criteria().orOperator(Criteria.where("match_mode").is(MatchMode.MANUAL), Criteria.where("match_mode").is(MatchMode.AUTO))
147-
), Criteria.where("status").is("EXECUTED")
148-
)
145+
new Criteria().andOperator(
146+
new Criteria().orOperator(Criteria.where("player_id_1").is(userId), Criteria.where("player_id_2").is(userId)),
147+
new Criteria().orOperator(Criteria.where("match_mode").is(MatchMode.MANUAL), Criteria.where("match_mode").is(MatchMode.AUTO))
148+
), Criteria.where("status").is("EXECUTED")
149+
)
149150
),
150151
sort(Sort.by("createdAt").descending()),
151152
skip((long) pageable.getPageNumber() * pageable.getPageSize()),
@@ -166,6 +167,8 @@ public List<PrivateMatchResponse> getManualAndAutoExecutedMatchesPaginated(Integ
166167
.username2(user2.getUsername())
167168
.avatar1(user1.getAvatarId())
168169
.avatar2(user2.getAvatarId())
170+
.score1(match.getScore1())
171+
.score2(match.getScore2())
169172
.verdict(match.getVerdict())
170173
.playedAt(match.getCreatedAt())
171174
.matchMode(match.getMatchMode())

0 commit comments

Comments
 (0)